Skip to content

feat(metrics): Use default resource labels for metrics. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proffalken merged 2 commits into from
Apr 27, 2026
Merged

feat(metrics): Use default resource labels for metrics. #14

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86ece0d
feat(metrics): Use default resource labels for metrics.
octo Apr 7, 2026
dddd74f
refactor(metrics): Use `OTelResourceConfig.empty()` accessor.
octo Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions include/OtelDefaults.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,11 @@ struct OTelResourceConfig {
// -------------------------------------------------------------------------------------------------

/** Default resource for general use (metrics/logs/etc.) */
static inline OTelResourceConfig& defaultResource() {
inline OTelResourceConfig& defaultResource() {
static OTelResourceConfig rc;
return rc;
}


} // namespace OTel

#endif // OTEL_DEFAULTS_H

6 changes: 6 additions & 0 deletions src/OtelMetrics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ static void addPointAttributes(JsonArray& attrArray,
}

static void addCommonResource(JsonObject& resource) {
auto &res = OTel::defaultResource();
if (!res.attrs.empty()) {
res.addResourceAttributes(resource);
return;
}

JsonArray rattrs = resource["attributes"].to<JsonArray>();
addResAttr(rattrs, "service.name", defaultServiceName());
addResAttr(rattrs, "service.instance.id", defaultServiceInstanceId());
Expand Down