Skip to content

docs(skills): add session-hygiene skill and mandatory gate - #424

Open
castrojo wants to merge 2 commits into
mainfrom
docs/session-hygiene-skill
Open

docs(skills): add session-hygiene skill and mandatory gate#424
castrojo wants to merge 2 commits into
mainfrom
docs/session-hygiene-skill

Conversation

@castrojo

Copy link
Copy Markdown
Contributor

What

New docs/skills/session-hygiene.md skill + routing in docs/SKILL.md + a mandatory gate in AGENTS.md.

Why

Codifies four working-session rules, each learned from a real maintainer course-correction in session history (/chronicle improve analysis):

  1. Disambiguate review targets — a generic /pulls link means list PRs and confirm; the local working tree is never the review target
  2. Reviews are read-only — propose fixes as text; edit only on explicit request
  3. Clean working tree at session end — commit, stash with a message, or revert; stranded uncommitted changes mislead the next session (a broken half-refactor sat uncommitted for two weeks and was presented to the maintainer as their own work)
  4. Answer-first communication — label unrelated workstreams separately; never blend 'do not merge' and 'merge this' without naming the artifact

Docs-only change — no action or reusable workflow files touched.

Consumer PR: N/A (docs-only; consumer-validation check only enforces on bootc-build/**/action.yml and reusable-*.yml changes)
Consumer CI run: N/A (docs-only)
Out-of-org consumer impact: N/A — no action behavior changes

Codifies four working-session rules learned from maintainer
course-corrections: disambiguate PR review targets (never substitute
the working tree), reviews are read-only, end sessions with a clean
working tree, and answer-first communication that separates unrelated
workstreams.

Assisted-by: Kimi K3 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@castrojo
castrojo requested a review from p5 as a code owner August 21, 2026 05:47
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-only skill addition. The four rules are concrete and each ties back to a specific real incident, which is exactly what makes a skill file worth having rather than generic advice. Routing table entries in docs/SKILL.md and the AGENTS.md gate summary are consistent with the new file's content, and the pattern matches how other skills in this repo are wired in. All 3 checks (dependency review, consumer-validation evidence, secret-reference scan) pass, as expected for a docs-only change with no action/workflow files touched.


Generated by Claude Code

Add When to Use / When NOT to Use / Common Rationalizations / Red
Flags / Verification sections per the end-session audit checklist.

Assisted-by: Kimi K3 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants