docs(ci): explain the nested testsuite workflow refs - #1077
Merged
Conversation
5 tasks
Stable-promotion triage reads `test_ref: v1` as proof that the testsuite is current. It is not: a reusable workflow carries two independent refs, and `uses` -- which selects the workflow body, including fixes like VM disk sizing -- moves separately from the test tree `test_ref` checks out. Pinning one and managing the other leaves half the stack stale while the caller looks managed. Adds the triage row and the explanation to the CI failure-mode reference. Supersedes #1014, whose branch could no longer be merged: it had accumulated 16 conflicts against main -- workflows, Containerfile, unit tests -- for a change that touches one documentation file. Re-cut from current main so the diff is the change. Refs #929 Co-authored-by: Brian Ketelsen <bketelsen@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: castrojo <castrojo@users.noreply.github.com> (cherry picked from commit f05a382)
castrojo
force-pushed
the
fix/nested-testsuite-refs
branch
from
August 9, 2026 18:49
f05a382 to
ba3484a
Compare
hanthor
approved these changes
Aug 16, 2026
hanthor
left a comment
Member
There was a problem hiding this comment.
Small, accurate docs addition: uses (workflow definition) and test_ref (test tree) on a reusable testsuite workflow do move independently, so a managed test_ref next to a pinned uses is a real trap — workflow-level fixes (VM sizing, runner setup) don't arrive just because the test tree ref is current. Good judgement re-cutting this from current main instead of resolving 16 unrelated conflicts on the superseded #1014, with authorship preserved in the trailer. One file, 13 lines, no workflow behavior changed. CI is green.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you solving?
Stable-promotion triage can read
test_ref: v1as proof that every testsuite fix is current. It is not. A reusable workflow carries two independent refs:usesselects the workflow definition — including workflow-level fixes such as VM disk sizingtest_refselects the test tree that workflow checks outThey move separately, so a managed
test_refbeside a pinnedusesleaves half the stack stale while the caller looks managed.Changes
usesref with its test checkout refOne file, 13 added lines.
Relationship to #1014
This supersedes #1014, which carried the same insight but could no longer be merged: its branch had accumulated 16 conflicts against main —
Containerfile, five workflows,build_files/, unit tests,renovate.json— for a change that touches one documentation file. Resolving those to land a docs addition would have produced a diff nobody could review against the change it claims to make, so it is re-cut from currentmaininstead. Authorship is preserved in the commit trailer.The content was also re-checked against
main:failure-modes.mdhas grown a lot since #1014 was opened, but nothing in it covers the nested-ref distinction, so the contribution is still needed.Testing
python3 .github/scripts/validate-docs.py→documentation ok: 13 skills, 41 Markdown filesRefs #929