Skip to content

test(docs): add regression tests for skill validators - #923

Closed
kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
quality/test-docs-skill-validators
Closed

test(docs): add regression tests for skill validators#923
kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
quality/test-docs-skill-validators

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

Test Improvement

Adds regression coverage for docs validator scripts for broken relative links, missing skill front matter, skill catalog generation, and stale index detection.

Also wires new test module into just test python pytest invocation.

Related Issue

Fixes #910


Filed by quality agent (hold-gated mode). Human review required.

Add pytest coverage for docs validator scripts used by pre-commit:\n- broken relative markdown links\n- missing skill front matter\n- skill catalog generation and stale index detection\n\nAlso wire new test file into Justfile pytest invocation and regenerate skill catalog artifacts required by validator check.\n\nAssisted-by: GPT-5.3-Codex via GitHub Copilot\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Signed-off-by: quality[bot] <quality[bot]@users.noreply.github.com>
@kubestellar-hive
kubestellar-hive Bot requested review from a team and repires as code owners August 3, 2026 15:58
@clubanderson

Copy link
Copy Markdown

Marking for hold-gated flow: please apply labels quality, testing, and hold. This PR is not for merge automation.

@castrojo

castrojo commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Closing as redundant with coverage already on main.

#911 (merged) already added tests for three of the four areas this PR covers, in tests/test_skill_docs.py:

  • check_doc_linkstest_check_doc_links_passes_with_complete_catalog, test_check_doc_links_reports_missing_link
  • check_skill_frontmattertest_check_skill_frontmatter_passes_with_valid_files, test_check_skill_frontmatter_reports_missing_front_matter
  • generate_skill_indextest_generate_skill_index_round_trip, test_generate_skill_index_rejects_missing_entry_point, plus stale-date coverage added in fix(ci): stop validate failing on stale generated_at date #937

Landing this would create a second parallel test file (tests/test_docs_skill_validators.py) duplicating the same validators, which splits maintenance across two files.

The one genuinely uncovered validator was check-skill-index — that gap is being closed by #924 instead. It's worth noting that gap was real: check-skill-index failed on main tonight (a missing queue-feed.md link in docs/SKILL.md), which failed the required validate job on every open PR until it was fixed.

Sibling PR #924 covers issue #910. No coverage is lost by closing this.

@castrojo castrojo closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] Add regression tests for docs skill validators

2 participants