feat: add non-media service-catalog lane + pipeline wiring#203
Open
clubanderson wants to merge 1 commit into
Open
feat: add non-media service-catalog lane + pipeline wiring#203clubanderson wants to merge 1 commit into
clubanderson wants to merge 1 commit into
Conversation
…uefin#81) - Add tests/service_catalog/nonmedia/ lane: 15 tests (13 active + 2 explicit skips for USB/mDNS hardware deferred to projectbluefin#67) - Add raw-manifest fixtures: nonmedia-pvc.yaml + nonmedia-service.yaml (nginx stub on port 631 for network-only IPP contract) - Add argo/workflow-templates/homelab-nonmedia-service.yaml: DAG with create-namespace → deploy-fixture → run-tests (onExit cleanup), delegates runner pod to run-incluster-tests/run-pytest template - Add argo/workflow-templates/bluefin-service-catalog-pipeline.yaml: top-level aggregation pipeline routing lane=nonmedia to the matching WorkflowTemplate; extensible for future lanes - Add argo/homelab-nonmedia-service.yaml: Workflow submit trigger - Add Justfile target run-service-nonmedia - Update WORKFLOWS.md: homelab-nonmedia-service and bluefin-service-catalog-pipeline contracts documented - Update RUNBOOK.md: 4 new service-catalog failure mode rows Out of scope: USB printer passthrough (projectbluefin#67), avahi mDNS (projectbluefin#67), GPU (projectbluefin#63) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hanthor
approved these changes
Jun 6, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
LGTM — well-structured test/infra addition, clean code.
6 tasks
hanthor
requested changes
Jun 16, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
Architecture issue: pipeline consolidation needed. This PR introduces bluefin-service-catalog-pipeline as a routing DAG, but #202 defines the canonical service-catalog-pipeline which is lane-agnostic. Two pipeline templates with different architectures create maintenance confusion.
Required changes:
- Rebase on top of #202. Use the lane-agnostic service-catalog-pipeline from #202 (with lane=nonmedia) rather than a separate routing DAG.
- Fix naming: homelab-nonmedia-service vs service-catalog-pipeline conflict. Pick one prefix.
- Fix entry point: Justfile recipe calls homelab-nonmedia-service directly, bypassing the pipeline. #204 correctly uses service-catalog-pipeline.
Builds on: #202 (must merge first)
hanthor
approved these changes
Jul 1, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
Review: Approved ✅
Part of the structured service-catalog project build-up. Conventional Commits format, referenced issues, consistent with related PRs in the series.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #81.
Implements the first non-media service lane in the service-catalog pipeline, proving the base homelab workload contract for network-only print services (OpenPrinting/CUPS class, bluespeed#11).
Changes
Tests
tests/service_catalog/nonmedia/__init__.py— package inittests/service_catalog/nonmedia/test_nonmedia_lane.py— 15 tests (13 active + 2 explicit skips for USB/mDNS hardware deferred to feat: split printer-device access and LAN discovery from the base non-media lane #67)tests/service_catalog/nonmedia/fixtures/nonmedia-pvc.yaml— PVC raw manifest (1Gi RWO)tests/service_catalog/nonmedia/fixtures/nonmedia-service.yaml— Deployment + Service manifests (nginx stub on port 631 for network-only IPP contract)Argo WorkflowTemplates
argo/workflow-templates/homelab-nonmedia-service.yaml— DAG:create-namespace → deploy-fixture → run-testswithonExit: cleanup. Delegates the runner pod torun-incluster-tests/run-pytest.argo/workflow-templates/bluefin-service-catalog-pipeline.yaml— Top-level aggregation pipeline routinglane=nonmediato the matching WorkflowTemplate; extensible for future lanes.argo/homelab-nonmedia-service.yaml— Workflow submit trigger.Operator surfaces
Justfile: new targetrun-service-nonmediaunder a new Service-catalog workload lanes section.WORKFLOWS.md:homelab-nonmedia-serviceandbluefin-service-catalog-pipelinecontracts documented.RUNBOOK.md: 4 new service-catalog failure mode rows (PVC not Bound, pod Pending, TEST_NAMESPACE unset, namespace finalizer hang).Out of scope (separate PRs/lanes)
Testing
Lane tests are designed to run inside the cluster via
just run-service-nonmedia(submitshomelab-nonmedia-serviceWorkflowTemplate). The fixture keeps the base lane on the network-only contract per issue guidance.