sec: use default serviceaccount for tenantresources by default#2029
Open
oliverbaehler wants to merge 2 commits into
Open
sec: use default serviceaccount for tenantresources by default#2029oliverbaehler wants to merge 2 commits into
oliverbaehler wants to merge 2 commits into
Conversation
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Capsule Helm chart defaults to enable TenantResource impersonation via a default ServiceAccount (default) out of the box, and aligns the chart schema/docs with that breaking default change.
Changes:
- Sets
manager.options.impersonation.tenantDefaultServiceAccountdefault to"default"invalues.yaml. - Extends
values.schema.jsonto recognizetenantDefaultServiceAccountundermanager.options.impersonation. - Updates the chart README’s “changed values” table to reflect the new default impersonation object.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| charts/capsule/values.yaml | Enables a default TenantResource ServiceAccount under manager.options.impersonation. |
| charts/capsule/values.schema.json | Adds the new tenantDefaultServiceAccount value to the Helm values schema. |
| charts/capsule/README.md | Updates the documented default for the manager.options.impersonation value. |
Comment on lines
+308
to
+312
| # Default ServiceAccount for tenant resources (TenantResource) [Namespaced Scope] | ||
| # When defined, users are required to use this ServiceAccount anywhere in the cluster | ||
| # unless they explicitly provide their own. Once this is set, Capsule will add this ServiceAccount | ||
| # for all GlobalTenantResources, if they don't already have a ServiceAccount defined. | ||
| tenantDefaultServiceAccount: "default" |
Comment on lines
+476
to
+478
| "tenantDefaultServiceAccount": { | ||
| "type": "string" | ||
| } |
| | manager.options.generateCertificates | bool | `true` | Specifies whether capsule webhooks certificates should be generated by capsule operator | | ||
| | manager.options.ignoreUserWithGroups | list | `[]` | Define groups which when found in the request of a user will be ignored by the Capsule this might be useful if you have one group where all the users are in, but you want to separate administrators from normal users with additional groups. | | ||
| | manager.options.impersonation | object | `{}` | Impersonation | | ||
| | manager.options.impersonation | object | `{"tenantDefaultServiceAccount":"default"}` | Impersonation | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change and will be disclosed via docs. However we are flooded with Advisories (irrelevant) and this change invalidates all of them.