Skip to content

fix(exposition): export internal package for OSGi resolution #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arimu1 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(exposition): export internal package for OSGi resolution #2415

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
687e885
fix(exposition): export internal package for OSGi resolution
arimu1 Aug 24, 2026
991921d
Merge branch 'main' into fix/2395-osgi-expositionformats-internal
jaydeluca Aug 24, 2026
bc2860e
test(exposition): assert OSGi export of internal package
arimu1 Aug 26, 2026
0e7138a
fix(exposition): drop SNAPSHOT OSGi versions and optional import
arimu1 Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions prometheus-metrics-exposition-formats-shaded/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,21 @@

<build>
<plugins>
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<configuration>
<instructions>
<!-- Required for OSGi: textformats loads protobuf impl via Class.forName -->
<Export-Package>
io.prometheus.metrics.expositionformats.generated*;version="${project.version}"
</Export-Package>
<_exportcontents>
io.prometheus.metrics.expositionformats.internal;version="${project.version}"
</_exportcontents>
Comment thread
zeitlinger marked this conversation as resolved.
</instructions>
Comment thread
zeitlinger marked this conversation as resolved.
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-resources-plugin</artifactId>
Expand Down
15 changes: 15 additions & 0 deletions prometheus-metrics-exposition-formats/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,21 @@

<build>
<plugins>
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<configuration>
<instructions>
<!-- Required for OSGi: textformats loads protobuf impl via Class.forName -->
Comment thread
zeitlinger marked this conversation as resolved.
Outdated
<Export-Package>
io.prometheus.metrics.expositionformats.generated*;version="${project.version}"
</Export-Package>
<_exportcontents>
io.prometheus.metrics.expositionformats.internal;version="${project.version}"
</_exportcontents>
</instructions>
</configuration>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
Expand Down