-
Notifications
You must be signed in to change notification settings - Fork 7
feat: postgres dialect suppport #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mrsufgi
wants to merge
13
commits into
protobom:main
Choose a base branch
from
mrsufgi:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
528bcbb
fix-nodelist-not-created
mrsufgi 0a19c18
fix: duplicate list
mrsufgi ee66c35
fix: nit
mrsufgi cff3399
fix: nit
mrsufgi aab9030
feat(backends): add pg driver
mrsufgi ae33034
fix: pg support in migrations
mrsufgi b627e0b
fix: pg conflicts
mrsufgi acfecf2
fix: annotations in pg
mrsufgi 540272e
fix: dont set documentid on annotation
mrsufgi 3a72308
fix: concurrent pg
mrsufgi 903cca0
test: pg integration tests
mrsufgi 9936406
test: integration tests and cleanups
mrsufgi 8abfddc
chore: update protobom
mrsufgi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -109,7 +109,7 @@ func (backend *Backend) AddNodeAnnotations(nodeID, name string, values ...string | |
| Where(node.NativeIDEQ(nodeID)). | ||
| All(backend.ctx) | ||
| if err != nil { | ||
| return fmt.Errorf("querying documents: %w", err) | ||
| return fmt.Errorf("querying nodes: %w", err) | ||
| } | ||
|
|
||
| for idx := range nodes { | ||
|
|
@@ -452,20 +452,11 @@ func (backend *Backend) SetNodeUniqueAnnotation(nodeID, name, value string) erro | |
| annotations := ent.Annotations{} | ||
|
|
||
| for idx := range nodes { | ||
| documentID, err := nodes[idx]. | ||
| QueryNodeLists(). | ||
| QueryDocuments(). | ||
| OnlyID(backend.ctx) | ||
| if err != nil { | ||
| return fmt.Errorf("querying node edges for document ID: %w", err) | ||
| } | ||
|
|
||
| annotations = append(annotations, &ent.Annotation{ | ||
| DocumentID: &documentID, | ||
| NodeID: &nodes[idx].ID, | ||
| Name: name, | ||
| Value: value, | ||
| IsUnique: true, | ||
| NodeID: &nodes[idx].ID, | ||
| Name: name, | ||
| Value: value, | ||
| IsUnique: true, | ||
|
Comment on lines
455
to
+459
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In Hooks, we never allowed setting both NodeID and DocumentID; they are mutually exclusive. This fixes it.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great catch! |
||
| }) | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.PHONYsincetest-integrationisn't a real file