Set content length for empty stream uploads#7452
Closed
Sean-Kenneth-Doherty wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content-Length: 0for empty file-like uploads instead ofTransfer-Encoding: chunkedFixes #6294.
Testing
uv run --group test pytest tests/test_requests.py -k "empty_stream_with_auth or empty_file_stream or explicit_zero_content_length_stream or unknown_length_file_stream or chunked_upload_does_not_set_content_length_header or stream_with_auth_does_not_set_transfer_encoding_header"uv run --group test pytest tests/test_utils.py -k super_lenuv run --group test pytest tests/test_lowlevel.pyuv run --group typecheck pyright src/requests/models.py src/requests/utils.pyuv run --with ruff ruff check src/requests/models.py src/requests/utils.py tests/test_requests.pyuv run --with ruff ruff format --check src/requests/models.py src/requests/utils.py tests/test_requests.pyuv run python -m compileall -q src/requests tests/test_requests.py tests/test_utils.py tests/test_lowlevel.pyuv run --no-sync pytest tests/test_requests.py