Fix batched forceFlush failure and make batching linear#5
Open
zeitlinger wants to merge 3 commits intopsx95:issue-8245from
Open
Fix batched forceFlush failure and make batching linear#5zeitlinger wants to merge 3 commits intopsx95:issue-8245from
zeitlinger wants to merge 3 commits intopsx95:issue-8245from
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
zeitlinger
changed the title
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
psx95
reviewed
Apr 23, 2026
| assertThat(reader.forceFlush().join(10, TimeUnit.SECONDS).isSuccess()).isTrue(); | ||
| assertThat(reader.forceFlush().join(10, TimeUnit.SECONDS).isSuccess()).isFalse(); | ||
| assertThat(reader.forceFlush().join(10, TimeUnit.SECONDS).isSuccess()).isFalse(); | ||
| assertThat(reader.forceFlush().join(10, TimeUnit.SECONDS).isSuccess()).isTrue(); |
Owner
There was a problem hiding this comment.
Now that the forceFlush() change has been reverted, these tests should be updated as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forceFlush()result inPeriodicMetricReaderMetricExportBatchertrack current batch point count incrementally so batching stays linear instead of rescanning the active batch for every metricTesting
./gradlew :sdk:metrics:test --tests io.opentelemetry.sdk.metrics.export.PeriodicMetricReaderTest --tests io.opentelemetry.sdk.metrics.export.MetricExportBatcherTestThis is a small follow-up to open-telemetry#8296 addressing:
forceFlush()success-reporting bug after a failed batch export