Repository navigation
fix(example): prevent layout shift from the loading spinner - #586
Merged
Merged
Conversation
The loading icon was taller than the text line, so the State row grew when a run started and pushed the content below it down. Give the row a fixed height that already fits the icon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6kYMtaicjNaZfA6SntAq4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the example page, the loading icon shown next to "Run without EventReduce.." / "Run with EventReduce.." is taller than the text line. The State row grew from 15px to 25px whenever a run started, which pushed everything below it down by 10px.
The State row now has a fixed 20px height that fits the icon. The value is a flex row with the icon vertically centered, so its height no longer depends on whether the spinner is shown.
I checked this in Chromium by measuring the row and the Actions panel in the idle and running states:
Generated by Claude Code