Skip to content

fix(paths): Resolve env vars before applying prefix to dependency paths #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moshe-elastix wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

fix(paths): Resolve env vars before applying prefix to dependency paths #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1572,8 +1572,14 @@ impl PrefixPaths for PathBuf {

impl PrefixPaths for String {
fn prefix_paths(self, prefix: &Path) -> Result<Self> {
// env is resolved later, convert back to string here.
Ok(prefix.join(PathBuf::from(&self)).display().to_string())
// Resolve env vars first so absolute results bypass the prefix.
let substituted = env_string_from_string(&self)?;
let path = PathBuf::from(&substituted);
if path.is_absolute() {
Ok(substituted)
} else {
Ok(prefix.join(&path).display().to_string())
}
}
}

Expand Down
Loading