-
Notifications
You must be signed in to change notification settings - Fork 37
Implement connectivity check for analytics endpoint and update URL to… #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ronilmitra7
wants to merge
1
commit into
develop
Choose a base branch
from
feature-auto-disable-analytics
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't see why we are changing the vex port filter in an internet connectivity check PR, this should be removed/moved to a different PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Compiled Object files | ||
| *.o | ||
| *.obj | ||
|
|
||
| # Executables | ||
| *.bin | ||
| *.elf | ||
|
|
||
| # PROS | ||
| bin/ | ||
| .vscode/ | ||
| .cache/ | ||
| compile_commands.json | ||
| temp.log | ||
| temp.errors | ||
| *.ini | ||
| .d/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| ################################################################################ | ||
| ######################### User configurable parameters ######################### | ||
| # filename extensions | ||
| CEXTS:=c | ||
| ASMEXTS:=s S | ||
| CXXEXTS:=cpp c++ cc | ||
|
|
||
| # probably shouldn't modify these, but you may need them below | ||
| ROOT=. | ||
| FWDIR:=$(ROOT)/firmware | ||
| BINDIR=$(ROOT)/bin | ||
| SRCDIR=$(ROOT)/src | ||
| INCDIR=$(ROOT)/include | ||
|
|
||
| WARNFLAGS+= | ||
| EXTRA_CFLAGS= | ||
| EXTRA_CXXFLAGS= | ||
|
|
||
| # Set to 1 to enable hot/cold linking | ||
| USE_PACKAGE:=1 | ||
|
|
||
| # Add libraries you do not wish to include in the cold image here | ||
| # EXCLUDE_COLD_LIBRARIES:= $(FWDIR)/your_library.a | ||
| EXCLUDE_COLD_LIBRARIES:= | ||
|
|
||
| # Set this to 1 to add additional rules to compile your project as a PROS library template | ||
| IS_LIBRARY:=0 | ||
| # TODO: CHANGE THIS! | ||
| # Be sure that your header files are in the include directory inside of a folder with the | ||
| # same name as what you set LIBNAME to below. | ||
| LIBNAME:=libbest | ||
| VERSION:=1.0.0 | ||
| # EXCLUDE_SRC_FROM_LIB= $(SRCDIR)/unpublishedfile.c | ||
| # this line excludes opcontrol.c and similar files | ||
| EXCLUDE_SRC_FROM_LIB+=$(foreach file, $(SRCDIR)/main,$(foreach cext,$(CEXTS),$(file).$(cext)) $(foreach cxxext,$(CXXEXTS),$(file).$(cxxext))) | ||
|
|
||
| # files that get distributed to every user (beyond your source archive) - add | ||
| # whatever files you want here. This line is configured to add all header files | ||
| # that are in the directory include/LIBNAME | ||
| TEMPLATE_FILES=$(INCDIR)/$(LIBNAME)/*.h $(INCDIR)/$(LIBNAME)/*.hpp | ||
|
|
||
| .DEFAULT_GOAL=quick | ||
|
|
||
| ################################################################################ | ||
| ################################################################################ | ||
| ########## Nothing below this line should be edited by typical users ########### | ||
| -include ./common.mk |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should permanently disable it if the user doesn't have internet once. User preferences should only be set by users, not automatically IMO. It is fine to just not send it for this command, and go back to user preferences for the next one.