Skip to content

perf: short-circuit COO.reshape when -1 resolves to self.shape #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hameerabbasi merged 2 commits into from
Apr 22, 2026
+3 −3
Merged

perf: short-circuit COO.reshape when -1 resolves to self.shape #935

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71bbf2d
perf: short-circuit COO.reshape when -1 resolves to self.shape
thodson-usgs Apr 21, 2026
487809e
perf: use `-1 in shape` for presence check in COO.reshape
thodson-usgs Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sparse/numba_backend/_coo/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,11 +1070,11 @@ def reshape(self, shape, order="C"):
if order not in {"C", None}:
raise NotImplementedError("The `order` parameter is not supported")

if self.shape == shape:
return self
if any(d == -1 for d in shape):
if -1 in shape:
extra = int(self.size / np.prod([d for d in shape if d != -1]))
shape = tuple([d if d != -1 else extra for d in shape])
if self.shape == shape:
return self

if self.size != reduce(operator.mul, shape, 1):
raise ValueError(f"cannot reshape array of size {self.size} into shape {shape}")
Expand Down
Loading