Repository navigation
fix(ci): report proper exit code in deploy_multiarch.sh - #2002
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The failure state is consistently recorded for all annotated errors and correctly returned after processing.
0 open findings
What changed in this PR
Ensures multi-architecture deployment failures propagate to GitHub Actions.
Changes:
- Tracks manifest creation and push failures.
- Exits nonzero when any deployment operation fails.
| File | Description |
|---|---|
deploy_multiarch.sh |
Accumulates deployment failures and returns the appropriate exit code. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In run https://github.com/pypa/manylinux/actions/runs/37987958535/attempts/1, we can see error annotations but the exit code of the script does not reflect those.
It wasn't a big issue and maybe was even done on purpose when the script ran everyday and images were built on different CI with one failing regularly and hence would have sent mails everyday. Now that everything runs in GHA and only on push to main, we definitely wan't to fail the workflow.
xref pypa/cibuildwheel#3009