-
Notifications
You must be signed in to change notification settings - Fork 346
docs(history): clarify that channel choice affects OHLC candle values #3786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aditya520
wants to merge
1
commit into
main
Choose a base branch
from
hydra/i-hpwotibg/head
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Example candle high (450.01) contradicts the sample price data (max 450.00000)
The worked example at lines 134–139 lists four specific prices "published around market close" on
fixed_rate@50ms, the highest being450.00000. However, the candle high table at line 145 claims thereal_time/fixed_rate@50mscandle high is450.01— a value that exceeds every price shown in the sample data. This is internally contradictory: a candle high cannot exceed the maximum published price within the window. Either the sample data table is missing rows that include a450.01tick, or the candle high should be450.00000(or450.00). As written, the example will confuse developers trying to learn how channel resolution affects candle values, which undermines the purpose of the new documentation.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.