fix(contract-manager): preserve nativeToken during chain serialization - #3855
Open
Ysh204 wants to merge 1 commit into
Open
fix(contract-manager): preserve nativeToken during chain serialization#3855Ysh204 wants to merge 1 commit into
Ysh204 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 4 Skipped Deployments
|
|
@Ysh204 is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Ysh204
force-pushed
the
fix/preserve-native-token-serialization
branch
from
June 29, 2026 07:51
b1420e1 to
f197d02
Compare
Author
|
@devin-ai-integration please re-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3854 by preserving
nativeTokenduring chain serialization in@pythnetwork/contract-manager.Details
Several
Chainimplementations deserializenativeTokeninfromJson()but do not serialize it back intoJson(). As a result, afromJson() → toJson()round trip drops the configurednativeToken, and persistence paths that rely ontoJson()lose this metadata.This PR restores serialization symmetry by preserving
nativeTokenintoJson()for the affected chain implementations.Testing
fromJson() → toJson() → fromJson()round trips for all affected chain classes.Fixes #3854