Skip to content

feat(evm): add MigrateGovernanceAndWormhole governance action - #3937

Open
keyvankhademi wants to merge 3 commits into
mainfrom
feat/evm-gov-set-wormhole-and-datasources
Open

feat(evm): add MigrateGovernanceAndWormhole governance action#3937
keyvankhademi wants to merge 3 commits into
mainfrom
feat/evm-gov-set-wormhole-and-datasources

Conversation

@keyvankhademi

@keyvankhademi keyvankhademi commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds Target governance action 10 MigrateGovernanceAndWormhole for legacy → pro-compatible in-place cutover.
  • Atomically sets wormhole (no dual-VAA re-verify), replaces valid data sources, sets the new governance emitter, bumps governanceDataSourceIndex, and resets lastExecutedGovernanceSequence to 0.
  • Fee is not part of this action — set to 0 beforehand via existing SetFee.
  • Leaves SetWormholeAddress dual-verify and AuthorizeGovernanceDataSourceTransfer unchanged (handoff cannot cross mismatched attestor sets).

Wire format (after PTGM header):
wormhole(20) | dataSources* | governanceEmitter(chain u16 + addr 32) | governanceDataSourceIndex(u32)

Sibling PRs:

  • xc_admin_common codec
  • contract_manager migrate tooling

Test plan

  • forge test --match-contract PythGovernance
  • Happy path: wormhole, data sources, governance DS/index, sequence 0; fee unchanged
  • Reverts: zero/no-code wormhole, zero governance emitter, stale index, chainId 0, trailing/truncated payload
  • Confirm actions 6 and authorize-transfer behavior unchanged

Enable legacy→pro-compatible in-place migration by setting wormhole,
data sources, and fee in one Target action without dual-VAA re-verify.
Copilot AI review requested due to automatic review settings July 28, 2026 20:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

7 Skipped Deployments
Project Deployment Actions Updated (UTC)
api-reference Skipped Skipped Jul 30, 2026 8:37pm
component-library Skipped Skipped Jul 30, 2026 8:37pm
developer-hub Skipped Skipped Jul 30, 2026 8:37pm
entropy-explorer Skipped Skipped Jul 30, 2026 8:37pm
insights Skipped Skipped Jul 30, 2026 8:37pm
proposals Skipped Skipped Jul 30, 2026 8:37pm
staking Skipped Skipped Jul 30, 2026 8:37pm

Request Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Fee is set to 0 beforehand via existing SetFee; action 10 only updates
wormhole address and data sources.
@vercel
vercel Bot temporarily deployed to Preview – insights July 29, 2026 23:00 Inactive
@vercel
vercel Bot temporarily deployed to Preview – entropy-explorer July 29, 2026 23:00 Inactive
@vercel
vercel Bot temporarily deployed to Preview – developer-hub July 29, 2026 23:00 Inactive
@vercel
vercel Bot temporarily deployed to Preview – proposals July 29, 2026 23:00 Inactive
@vercel
vercel Bot temporarily deployed to Preview – staking July 29, 2026 23:00 Inactive
@vercel
vercel Bot temporarily deployed to Preview – component-library July 29, 2026 23:00 Inactive
@vercel
vercel Bot temporarily deployed to Preview – api-reference July 29, 2026 23:00 Inactive
Atomically migrate wormhole, data sources, and governance emitter with a
strictly increasing index and sequence reset; fee remains a separate action.
@vercel
vercel Bot temporarily deployed to Preview – proposals July 30, 2026 20:37 Inactive
@vercel
vercel Bot temporarily deployed to Preview – insights July 30, 2026 20:37 Inactive
@vercel
vercel Bot temporarily deployed to Preview – developer-hub July 30, 2026 20:37 Inactive
@vercel
vercel Bot temporarily deployed to Preview – component-library July 30, 2026 20:37 Inactive
@vercel
vercel Bot temporarily deployed to Preview – entropy-explorer July 30, 2026 20:37 Inactive
@vercel
vercel Bot temporarily deployed to Preview – staking July 30, 2026 20:37 Inactive
@vercel
vercel Bot temporarily deployed to Preview – api-reference July 30, 2026 20:37 Inactive
@keyvankhademi keyvankhademi changed the title feat(evm): add SetWormholeAddressAndDataSources governance action feat(evm): add MigrateGovernanceAndWormhole governance action Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants