-
Notifications
You must be signed in to change notification settings - Fork 132
Refactor get_bottom_toolbar implementation in getting_started.py example #1703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+46
−5
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d4778b4
docs: add design spec for threaded toolbar update
tleonhardt 9be94aa
Don't commit superpowers design docs
tleonhardt ff33103
docs: add implementation plan for threaded toolbar update
tleonhardt cc45c00
Update GEMINI.md to tell superpowers not to commit specs or plans
tleonhardt 32e5b0b
docs: add design spec for getting_started bottom toolbar optimization
tleonhardt fd75fd7
docs: add implementation plan for getting_started bottom toolbar opti…
tleonhardt 7605b39
Update Gemini.md again to try to stop superpowers from saving its spe…
tleonhardt 0d775f7
Add superpowers directory to .gitignore
tleonhardt dbe71e8
Remove superpowers md files
tleonhardt f0b4022
feat(example): initialize state and worker for background toolbar thread
tleonhardt c50ae5e
Fix: Remove terminal width calculation from background thread in gett…
tleonhardt efefb2a
feat(example): add preloop and postloop hooks to manage toolbar thread
tleonhardt 1329f55
refactor(example): get_bottom_toolbar now reads from thread-safe cach…
tleonhardt 663eb03
fix(example): improve thread teardown safety with daemon=True and eve…
tleonhardt 6f786eb
Update file-header command and change background thread to run 4 time…
tleonhardt 33f2119
Add a type hint to fix mypy warnings
tleonhardt dbf5703
Make a comment more clear
tleonhardt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,3 +63,6 @@ package-lock.json | |
|
|
||
| # GitHub App credentials | ||
| gha-creds-*.json | ||
|
|
||
| # Superpowers extension | ||
| docs/superpowers | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.