Skip to content

[Cmd] use prompt-toolkit native clipboard integration#1721

Open
neoniobium wants to merge 11 commits into
python-cmd2:mainfrom
neoniobium:clipboard
Open

[Cmd] use prompt-toolkit native clipboard integration#1721
neoniobium wants to merge 11 commits into
python-cmd2:mainfrom
neoniobium:clipboard

Conversation

@neoniobium

Copy link
Copy Markdown
Contributor

Addresses #1720

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.59%. Comparing base (1a56c89) to head (c149c0b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1721      +/-   ##
==========================================
+ Coverage   99.57%   99.59%   +0.01%     
==========================================
  Files          23       22       -1     
  Lines        5915     5928      +13     
==========================================
+ Hits         5890     5904      +14     
+ Misses         25       24       -1     
Flag Coverage Δ
unittests 99.59% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Comment thread tests/test_cmd2.py Outdated
Comment thread cmd2/cmd2.py Outdated
Comment thread cmd2/cmd2.py Outdated
@tleonhardt

Copy link
Copy Markdown
Member

@neoniobium You'll need to merge master into your branch.

Btw, you should now be able to create branches in the main repo, so you don't need to use a Fork anymore unless you want to. Using branches in main repo, makes it easier for others to help collaborate.

@neoniobium

Copy link
Copy Markdown
Contributor Author

@neoniobium You'll need to merge master into your branch.

Btw, you should now be able to create branches in the main repo, so you don't need to use a Fork anymore unless you want to. Using branches in main repo, makes it easier for others to help collaborate.

Ok, next time I will create a branch instead of using my frok.

Comment thread cmd2/cmd2.py Outdated
Comment thread cmd2/cmd2.py Outdated
Comment thread cmd2/cmd2.py Outdated
Comment thread cmd2/cmd2.py Outdated
Comment thread tests/test_cmd2.py Outdated
@neoniobium

Copy link
Copy Markdown
Contributor Author

Thanks again for the review.

I was also thinking whether the clipboard should be shared will each session, or example read_secret. I think good arguments for either case. I would like to know your opinion on that point.

Furthermore I was wondering allow_clipboard is still a good variable name since is now allow a clipboard available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants