Skip to content

gh-143586: Add Counter comparison tests to enforce missing element semantics #143587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 2 commits into from
Jan 10, 2026
Merged

gh-143586: Add Counter comparison tests to enforce missing element semantics #143587

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd9fb4c
Add Counter comparison tests to enforce missing element semantics
heikkitoivonen Jan 8, 2026
d21fc0d
Tests do not need news entry
heikkitoivonen Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Lib/test/test_collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2423,6 +2423,8 @@ def test_eq(self):

def test_le(self):
self.assertTrue(Counter(a=3, b=2, c=0) <= Counter('ababa'))
self.assertTrue(Counter() <= Counter(c=1))
self.assertFalse(Counter() <= Counter(c=-1))
self.assertFalse(Counter(a=3, b=2) <= Counter('babab'))

def test_lt(self):
Expand All @@ -2431,6 +2433,8 @@ def test_lt(self):

def test_ge(self):
self.assertTrue(Counter(a=2, b=1, c=0) >= Counter('aab'))
self.assertTrue(Counter() >= Counter(c=-1))
self.assertFalse(Counter() >= Counter(c=1))
self.assertFalse(Counter(a=3, b=2, c=0) >= Counter('aabd'))

def test_gt(self):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2026-01-08-15-04-38.gh-issue-143586.jLL4wL.rst
View file
Open in desktop
Comment thread
heikkitoivonen marked this conversation as resolved.
Outdated
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add ``collections.Counter`` comparison tests to enforce missing element semantics.
Loading