Open
Conversation
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
JelleZijlstra
requested review from
a team,
AA-Turner,
AlexWaygood,
ZeroIntensity,
emmatyping,
ericsnowcurrently and
erlend-aasland
as code owners
5 tasks
eendebakpt
reviewed
Apr 22, 2026
eendebakpt
reviewed
Apr 22, 2026
eendebakpt
reviewed
Apr 22, 2026
eendebakpt
reviewed
Apr 22, 2026
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
hugovk
reviewed
Apr 24, 2026
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
JelleZijlstra
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 53a84b6 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F148831%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
ZeroIntensity
approved these changes
Apr 24, 2026
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
The C code and the corresponding documentation look good to me. I didn't look very closely at the tests.
sunmy2019
reviewed
Apr 24, 2026
| assert(PyFunction_Check(func)); | ||
| PyObject *r = PyFunction_GetModule((PyObject *)func); | ||
| if (!r) { | ||
| Py_RETURN_NONE; |
Member
There was a problem hiding this comment.
Do we need a PyErr_Clear() here? (since if error occurs, usually we will return NULL)
Member
Author
There was a problem hiding this comment.
@ZeroIntensity asked me to remove it (#148831 (comment)) because there is no scenario where this function can return NULL without an exception set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces JelleZijlstra#4. See python/steering-council#258.
📚 Documentation preview 📚: https://cpython-previews--148831.org.readthedocs.build/