Skip to content

changed to proper Xavier initialization, existing implementation was … #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eknag wants to merge 4 commits into from
Closed

changed to proper Xavier initialization, existing implementation was … #1927

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6201a73
changed to proper Xavier initialization, existing implementation was …
Sep 23, 2023
e7566ec
call zero_grad in dlrm training loop to stop gradients from accumulating
Sep 23, 2023
9f4b92d
Revert "call zero_grad in dlrm training loop to stop gradients from a…
Sep 23, 2023
5d2bf0f
added link to upstream PR
Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions torchbenchmark/models/dlrm/dlrm_s_pytorch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,7 @@ def create_mlp(self, ln, sigmoid_layer):
mean = 0.0 # std_dev = np.sqrt(variance)
std_dev = np.sqrt(2 / (m + n)) # np.sqrt(1 / m) # np.sqrt(1 / n)
W = np.random.normal(mean, std_dev, size=(m, n)).astype(np.float32)
std_dev = np.sqrt(1 / m) # np.sqrt(2 / (m + 1))
bt = np.random.normal(mean, std_dev, size=m).astype(np.float32)
bt = np.zeros(m).astype(np.float32)
# approach 1
LL.weight.data = torch.tensor(W, requires_grad=True)
LL.bias.data = torch.tensor(bt, requires_grad=True)
Expand Down