Probe device for skip on main thread

gloo/test/base_test.h

@@ -10,6 +10,7 @@
 
 #include <gtest/gtest.h>
 
+#include <atomic>
 #include <exception>
 #include <functional>
 #include <stdexcept>
@@ -112,18 +113,25 @@ class BaseTest : public ::testing::Test {
           device_creator,
       std::function<void(std::shared_ptr<Context>)> fn,
       int base = 2) {
+    // Track whether workers found the transport unavailable so we can call
+    // GTEST_SKIP() from the main thread after joining. GTEST_SKIP() is not
+    // thread-safe and must not be called from worker threads — doing so
+    // causes a data race on GTest internals that can manifest as
+    // "terminate called recursively" (SIGABRT / exit code 134).
+    std::atomic<bool> transportUnavailable{false};
+
     Barrier barrier(size);
     auto store = std::make_shared<::gloo::rendezvous::HashStore>();
 
     spawnThreads(size, [&](int rank) {
       auto context =
           std::make_shared<::gloo::rendezvous::Context>(rank, size, base);
 
-      // Create device per thread to avoid collisions then they are using the
+      // Create device per thread to avoid collisions when they are using the
       // socket address.
       auto device = device_creator(transport);
       if (!device) {
-        GTEST_SKIP() << "Skipping test: transport not available";
+        transportUnavailable.store(true);
         return;
       }
       context->connectFullMesh(store, device);
@@ -150,6 +158,10 @@ class BaseTest : public ::testing::Test {
         context->closeConnections();
       }
     });
+
+    if (transportUnavailable.load()) {
+      GTEST_SKIP() << "Skipping test: transport not available";
+    }
   }
 
   void spawn(

gloo/transport/ibverbs/device.cc

@@ -154,14 +154,22 @@ Device::~Device() {
   done_ = true;
   loop_->join();
 
+  // Log errors instead of throwing — destructors are implicitly noexcept
+  // in C++11+, so a throw here calls std::terminate().
   rv = ibv_destroy_comp_channel(comp_channel_);
-  GLOO_ENFORCE_EQ(rv, 0, strerror(errno));
+  if (rv != 0) {
+    GLOO_ERROR("ibv_destroy_comp_channel: ", strerror(errno));
+  }
 
   rv = ibv_dealloc_pd(pd_);
-  GLOO_ENFORCE_EQ(rv, 0, strerror(errno));
+  if (rv != 0) {
+    GLOO_ERROR("ibv_dealloc_pd: ", strerror(errno));
+  }
 
   rv = ibv_close_device(context_);
-  GLOO_ENFORCE_EQ(rv, 0, strerror(errno));
+  if (rv != 0) {
+    GLOO_ERROR("ibv_close_device: ", strerror(errno));
+  }
 }
 
 std::string Device::str() const {