Skip to content

Add more FCI L2 CRM and ASR datasets and fix warnings#3394

Open
strandgren wants to merge 9 commits into
pytroll:mainfrom
strandgren:add_more_seviri_fci_l2_asr_crm_datasets
Open

Add more FCI L2 CRM and ASR datasets and fix warnings#3394
strandgren wants to merge 9 commits into
pytroll:mainfrom
strandgren:add_more_seviri_fci_l2_asr_crm_datasets

Conversation

@strandgren

Copy link
Copy Markdown
Collaborator

This PR fixes a couple of issues with the EUMETSAT FCI L2 readers:

@strandgren strandgren requested review from gerritholl and pnuu May 19, 2026 10:26
@strandgren strandgren self-assigned this May 19, 2026
@strandgren strandgren moved this from Backlog to In review in PCW Spring 2026 May 19, 2026

@pnuu pnuu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.33%. Comparing base (a246cc2) to head (26c746c).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3394      +/-   ##
==========================================
+ Coverage   96.30%   96.33%   +0.03%     
==========================================
  Files         466      467       +1     
  Lines       59088    59142      +54     
==========================================
+ Hits        56906    56977      +71     
+ Misses       2182     2165      -17     
Flag Coverage Δ
behaviourtests 3.58% <0.00%> (-0.01%) ⬇️
unittests 96.42% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Reading FCI L2 data yields warning on chunking performance

2 participants