-
-
Notifications
You must be signed in to change notification settings - Fork 139
adding usb_control_in functionality #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zanobos
wants to merge
2
commits into
pyvisa:main
Choose a base branch
from
Zanobos:usb-control-in
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -248,7 +248,6 @@ def write(self, data): | |
| :param data: bytes to be sent to the instrument | ||
| :type data: bytes | ||
| """ | ||
|
|
||
| try: | ||
| return self.usb_send_ep.write(data) | ||
| except usb.core.USBError as e: | ||
|
|
@@ -431,3 +430,30 @@ def read(self, size): | |
| eom = response.transfer_attributes & 1 | ||
|
|
||
| return bytes(received) | ||
|
|
||
| def control_transfer(self, request_type_bitmap_field, request_id, request_value, | ||
| index, length): | ||
| """Performs a USB control pipe transfer from the device. | ||
|
|
||
| :param request_type_bitmap_field: bmRequestType parameter of the setup stage of a USB control transfer. | ||
| :param request_id: bRequest parameter of the setup stage of a USB control transfer. | ||
| :param request_value: wValue parameter of the setup stage of a USB control transfer. | ||
| :param index: wIndex parameter of the setup stage of a USB control transfer. | ||
| This is usually the index of the interface or endpoint. | ||
| :param length: wLength parameter of the setup stage of a USB control transfer. | ||
| This value also specifies the size of the data buffer to receive the data from the | ||
| optional data stage of the control transfer. | ||
| :return: - The data buffer that receives the data from the optional data stage of the control transfer | ||
| :rtype: - bytes | ||
| """ | ||
|
|
||
| self.usb_dev.ctrl_transfer(request_type_bitmap_field, | ||
| request_id, | ||
| request_value, | ||
| index, | ||
| length, | ||
| timeout=self.timeout) | ||
|
|
||
| #TODO satisfy the second half of the problem -i.e. sending buffer the optional data stage | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can try using to do a direct read. Using |
||
| # return self.read(length) does not work | ||
| return bytes() | ||
|
Zanobos marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.