Repository navigation
CCL-2382: add io_uring to storage performance config - #300
Closed
lakhansamani wants to merge 1 commit into
Closed
lakhansamani wants to merge 1 commit into
lakhansamani wants to merge 1 commit into
Conversation
Hybrid cloud only: a managed cluster ignores it and, from Qdrant v1.20.0, gets auto from Qdrant Cloud. async_scorer keeps working, so no Deprecated marker that would also warn hybrid users.
Author
|
Closing: CCL-2382 no longer exposes Qdrant checks for itself whether io_uring is available, so there is nothing to What remains of the ticket is the CRD field in qdrant/kubernetes-api#327 plus the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CCL-2382
Summary
Adds
database_configuration.storage.performance.io_uring. It is hybrid cloudonly: a managed cluster ignores it and, from Qdrant v1.20.0, gets
autofromQdrant Cloud.
async_scorerstays settable and only gains that note in itsdescription — no
Deprecatedmarker, which would also warn hybrid users.Two deviations from the spec, both deliberate:
(
DATABASE_CONFIGURATION_IO_URING_MODE_AUTO/..._DISABLED), notauto/disabled. Every other enum in this provider is exposed that way(
gpu_type,rebalance_strategy,log_level), and the flatten path uses.String(). Say the word if the friendlier spelling is wanted instead.Blocked, and not only on qdrant/qdrant-cloud-public-api#538. The pin here is
v0.201.0, and anything new enough to carry theio_uringenum also carriesqdrant/qdrant-cloud-public-api#519, which dropped
SpaceEndpoint.rest_portandgrpc_port.qdrant/schemas_serverless_space.gostill reads both, so thebuild fails there until the provider absorbs SVL-97 — a separate decision,
since those two fields are in the provider's public schema.
tfplugindocsneeds a working build, so docs regeneration waits on the same thing.
Tests
New
TestStoragePerformanceIOUringRoundTrip: expand -> proto -> flatten keepsthe mode, an unset mode stays absent instead of being sent as
"", and theschema validates only the enum names while staying Optional + Computed.
go test ./qdrant/— the cluster tests pass, verified by stubbing the twoserverless lines above locally; those stubs are not in this branch, so CI is
red until SVL-97 is handled.