FROMLIST: PCI: qcom: Set max OPP before DBI access during resume#647
Open
ziyuezhang-123 wants to merge 1 commit into
Open
FROMLIST: PCI: qcom: Set max OPP before DBI access during resume#647ziyuezhang-123 wants to merge 1 commit into
ziyuezhang-123 wants to merge 1 commit into
Conversation
ziyuezhang-123
requested review from
a team,
knaveen-qc,
ndechesne and
quicAspratap
|
Merge Check Failed: No Change Task Found No associated change tasks found for CR 4536367 on any of the following entities: Entities:
CR: 4536367 Please ensure the CR has a change task associated with at least one of the entities for this branch. |
During resume, qcom_pcie_icc_opp_update() may access DBI registers before the OPP votes are restored, which can trigger NoC errors. Set the PCIe controller to the maximum OPP first in resume_noirq(), then proceed with link/DBI accesses. The OPP is later updated again based on the actual link bandwidth requirements. Also introduce a small helper to reuse the max-OPP setup path shared with probe. Fixes: 5b6272e ("PCI: qcom: Add OPP support to scale performance") Link: https://lore.kernel.org/all/20260416-setmaxopp-v1-1-6a74e2d945a0@oss.qualcomm.com/ Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com> Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>
|
Merge Check Failed: No Change Task Found No associated change tasks found for CR 4536367 on any of the following entities: Entities:
CR: 4536367 Please ensure the CR has a change task associated with at least one of the entities for this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During resume, qcom_pcie_icc_opp_update() may access DBI registers before the OPP votes are restored, which can trigger NoC errors.
Set the PCIe controller to the maximum OPP first in resume_noirq(), then proceed with link/DBI accesses. The OPP is later updated again based on the actual link bandwidth requirements.
Also introduce a small helper to reuse the max-OPP setup path shared with probe.
Fixes: 5b6272e ("PCI: qcom: Add OPP support to scale performance")
Link: https://lore.kernel.org/all/20260416-setmaxopp-v1-1-6a74e2d945a0@oss.qualcomm.com/
CRs-Fixed: 4536367