fix: resolve failing tests and type errors across api and shared packages#80
Open
stooit wants to merge 1 commit into
Open
fix: resolve failing tests and type errors across api and shared packages#80stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…ages
- auth middleware: fix HTTP method case-sensitivity ('post' -> 'POST')
- shared types: rename User.userName -> username for cross-package consistency
- users route: add missing badRequest import from ../lib/errors
- shared pagination: implement paginate() per test contract
- tsconfig: reference bun-types to resolve process/bun:test type errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 9 failing tests and all
tsc --noEmittype errors. Final state: 22 tests pass, 0 fail, 0 type errors.Changes
packages/api/src/middleware/auth.ts'post'; methods arrive uppercase per RFC 7231, soPOST /userswas not treated as public. Changed to'POST'.packages/shared/src/types.tsUser.userName→usernameto match what route code and tests use (field-name inconsistency between packages).packages/api/src/routes/users.tsbadRequestimport from../lib/errors(was a runtimeReferenceError).packages/shared/src/utils/pagination.tspaginate()stub per the test contract (slice, total, totalPages, page, pageSize).tsconfig.json"types": ["bun-types"]to resolveprocess/bun:testtype errors.bun-typesships with Bun — no new dependency.Assumptions
username, so source conformed to tests.bun-typeswas already available via the Bun runtime; referencing it in tsconfig is config, not a new dependency.Verification
bun test→ 22 pass / 0 failnpx tsc --noEmit→ exit 0Constraints honoured
No test files modified. No new dependencies added. Minimal, targeted fixes only.