Skip to content

Fix type casting error in thc_jax.py #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhucka merged 2 commits into from
Jul 2, 2026
Merged

Fix type casting error in thc_jax.py #1396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89404f6
Fix type casting error
mhucka Jul 2, 2026
3d411bb
Need to cast it for mypy
mhucka Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/openfermion/resource_estimates/pbc/thc/factorizations/thc_jax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
# pylint: disable=wrong-import-position
import math
import time
from typing import cast

import h5py
import numpy as np
Expand Down Expand Up @@ -213,7 +214,7 @@ def compute_objective_batched(
lambda_z = jnp.sum(jnp.einsum("jpq->j", 0.5 * jnp.abs(mpq_normalized)) ** 2.0)

res = 0.5 * jnp.sum((jnp.abs(deri)) ** 2) + penalty_param * lambda_z
return float(res)
return cast(float, res)


def prepare_batched_data_indx_arrays(
Expand Down
Loading