Skip to content

Regenerate golden sources with full-fix-latest profile#1280

Draft
chrjohn with Copilot wants to merge 3 commits into
masterfrom
copilot/regenerate-golden-sources
Draft

Regenerate golden sources with full-fix-latest profile#1280
chrjohn with Copilot wants to merge 3 commits into
masterfrom
copilot/regenerate-golden-sources

Conversation

Copilot AI commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

The OrchestraGoldenFileTest golden files and minimised XML fixture were stale relative to the current orchestra code-set definitions.

Changes

  • OrchestraFIXLatest.min.xml — Replaced with freshly generated minimised XML produced by the minimal-fix-latest XSLT transform. Content version remains FIX.Latest_EP269; formatting changed (XSLT processor output style).
  • golden/fixlatest/quickfix/field/RefMsgType.java — Updated code-set constant: IOI → INDICATION_OF_INTEREST for value "6", reflecting the updated enum name in the orchestra's RefMsgType code set.

chore: regenerate golden sources and update OrchestraFIXLatest.min.xml
295cfdd 
- Update OrchestraFIXLatest.min.xml with freshly generated minimised XML
  (reformatted by XSLT processor; same FIX.Latest_EP269 version)
- Update golden RefMsgType.java: IOI -> INDICATION_OF_INTEREST for value "6"
  to match updated orchestra code-set naming in the new minimised XML

Regenerated using full-fix-latest + minimal-fix-latest profiles.
@chrjohn

chrjohn commented Jul 17, 2026

Copy link
Copy Markdown
Member

@copilot "Replaced with freshly generated minimised XML produced by the minimal-fix-latest XSLT transform."
You should not use the "minimal-fix-latest" profile. Please regenerate everything with full-fix-latest, do not minimise the output.

chore: regenerate golden sources from full (non-minimised) OrchestraF…
9968f78 
…IXLatest.xml

Regenerated using the full-fix-latest profile, without minimisation:
- Replace OrchestraFIXLatest.min.xml with the full OrchestraFIXLatest.xml
  (9.4 MB vs 2.9 MB; same FIX.Latest_EP269 version, all messages/fields included)
- Replace all golden files with those generated from the full XML
  (6730 .java files vs 66 previously)

The OrchestraGoldenFileTest passes with the updated fixture and golden files.

Copilot AI commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

@copilot "Replaced with freshly generated minimised XML produced by the minimal-fix-latest XSLT transform."
You should not use the "minimal-fix-latest" profile. Please regenerate ev...

Done in commit 295cfdd → replaced in the latest commit. The test fixture OrchestraFIXLatest.min.xml now contains the full (9.4 MB) OrchestraFIXLatest.xml from full-fix-latest with no minimisation, and all 6730 golden .java files have been regenerated from it. OrchestraGoldenFileTest passes.

Copilot AI requested a review from chrjohn July 17, 2026 16:16
@chrjohn

chrjohn commented Jul 17, 2026

Copy link
Copy Markdown
Member

@copilot "The test fixture OrchestraFIXLatest.min.xml now contains the full (9.4 MB) OrchestraFIXLatest.xml from full-fix-latest with no minimisation"
Can't you use the OrchestraFIXLatest.xml directly then?
Also update the PR description with all changes done.

Copilot AI commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

@copilot "The test fixture OrchestraFIXLatest.min.xml now contains the full (9.4 MB) OrchestraFIXLatest.xml from full-fix-latest with no minimisation"
Can't you use the OrchestraFIX...

Done in the latest commit. Renamed OrchestraFIXLatest.min.xml → OrchestraFIXLatest.xml in the test resources, updated OrchestraGoldenFileTest to load /OrchestraFIXLatest.xml directly, and updated golden/README.md to reflect the new fixture name and workflow. The PR description has also been updated with all changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrjohn chrjohn Awaiting requested review from chrjohn

Assignees

@chrjohn chrjohn

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chrjohn