Skip to content

test: test under ESLint v10#663

Merged
bmish merged 4 commits intoqunitjs:mainfrom
bmish:eslint-10-test
Feb 7, 2026
Merged

test: test under ESLint v10#663
bmish merged 4 commits intoqunitjs:mainfrom
bmish:eslint-10-test

Conversation

@bmish
Copy link
Copy Markdown
Member

@bmish bmish commented Feb 7, 2026

Fixes #655.

Title: chore: add ESLint 10 CI testing and remove deprecated type from test errors

Summary

  • Removed the type property from RuleTester error objects across 21 test files (168 instances). ESLint 10 throws if type is present in invalid test case errors. This is backward-compatible with ESLint 8/9 since type was always optional.
  • Added a CI step to run unit tests against ESLint 10 on Node 20.x, following the same pattern used historically when adding ESLint 8 support.
  • Bumped @typescript-eslint/parser to 8.54.0 for ESLint 10 compatibility (ScopeManager#addGlobals).

Test plan

  • All 1353 tests pass on both ESLint 9 and ESLint 10.

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 7, 2026

Pull Request Test Coverage Report for Build 21776073094

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 92.026%

Totals Coverage Status
Change from base Build 21775849975: 0.008%
Covered Lines: 998
Relevant Lines: 1072

💛 - Coveralls

@bmish bmish merged commit 4613e82 into qunitjs:main Feb 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

ESLint 10 support

2 participants