Update lockfile waiting message to reflect queued state - #227
Merged
Merged
Conversation
The previous message ("No checks have been run for this lockfile yet.")
implied nothing was happening. With Sidekiq concurrency at 2, checks
drain gradually, so the lockfile is actually queued and being processed.
The new message conveys that checks are running and results will appear
automatically, without telling the user to refresh (auto-update is
handled separately).
Closes #223
JuanVqz
commented
Jun 1, 2026
Co-authored-by: Juan Vásquez <javasgon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the empty-state message shown on a lockfile page when no checks have completed yet.
Before:
After:
Why
The old wording implied nothing was happening. With Sidekiq concurrency at 2, checks drain gradually, so the lockfile is actually queued and being processed, just not instantly.
The new message conveys that checks are running and results will appear automatically. It intentionally does not tell the user to refresh, since live auto-updating of the page is handled in a separate ticket.
Screenshot
Closes #223