Skip to content

fix: pin transitive qr to 0.5.5 to avoid border=0 crash#2678

Open
shottah wants to merge 2 commits into
rainbow-me:mainfrom
shottah:shottah/fix-qr-border-2677
Open

fix: pin transitive qr to 0.5.5 to avoid border=0 crash#2678
shottah wants to merge 2 commits into
rainbow-me:mainfrom
shottah:shottah/fix-qr-border-2677

Conversation

@shottah

@shottah shottah commented May 17, 2026

Copy link
Copy Markdown

Fixes #2677.

qr@0.6.0 rejects border=0, which crashes cuer's QR renderer. Pins qr to 0.4.2 via direct dep + pnpm override.

Temporary workaround until cuer#11 is merged and released.

qr@0.6.0 rejects border=0, which crashes cuer's QRCode renderer.
Pin via direct dep + pnpm override until cuer#11 is released.

Fixes rainbow-me#2677
@shottah shottah requested a review from a team as a code owner May 17, 2026 17:08
@changeset-bot

changeset-bot Bot commented May 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 63f751a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@rainbow-me/rainbowkit Patch
example Patch
@rainbow-me/rainbow-button Patch
rainbowkit-next-app Patch
site Patch
with-create-react-app Patch
with-next-app-i18n Patch
with-next-app Patch
with-next-custom-button Patch
with-next-mint-nft Patch
with-next-siwe-iron-session Patch
with-next-siwe-next-auth Patch
with-next-wallet-button Patch
with-next Patch
with-react-router Patch
with-remix Patch
with-vite Patch
with-next-rainbow-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented May 17, 2026

Copy link
Copy Markdown

@shottah is attempting to deploy a commit to the rainbowdotme Team on Vercel.

A member of the Team first needs to authorize it.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 23b18c1b41

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/rainbowkit/package.json Outdated
qr@0.5.0+ declares engines.node >= 20.19.0, which would raise
RainbowKit's published Node floor from >=12.4. 0.4.2 has no engines
field, accepts border=0, and matches cuer's original tested baseline.

Addresses Codex review on rainbow-me#2678.
@shottah

shottah commented May 17, 2026

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] qr version 0.6.0 throws errors when border=0

1 participant