[codex] Keep saved conversation opens in saved routes#20
Open
katalinawinemixer wants to merge 1 commit into
Open
[codex] Keep saved conversation opens in saved routes#20katalinawinemixer wants to merge 1 commit into
katalinawinemixer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
open →navigation inside/saved/:runIdwhen a conversation turn is already saved/runs/:runIdfallback for unsaved sibling turnsWhy
When viewing a saved trace conversation, clicking
open →on a turn always navigated throughrunPath, which sends the user to/runs/:runId. That kicks users out of the Saved workflow even when the target turn is saved and available under/saved/:runId.Root cause
RunDetailreused the local conversation viewer across route namespaces, but theConvoDetailcallback hard-codednavigate(runPath(id)). The fix routes saved conversation targets throughtracePath("/saved", id)when appropriate, and keeps the runs route as the fallback.Test plan
cd app && bun x playwright test tests-e2e/workshop-actions.spec.ts -g "saved conversation"cd app && bun x playwright test tests-e2e/workshop-actions.spec.tsbun run lint(passes with existing hook warnings, 0 errors)bun run buildgit diff --check