rainix-sol test workflow: add RPC_URL_HYPEREVM_FORK secret slot - #286
Open
hardyjosh wants to merge 1 commit into
Open
rainix-sol test workflow: add RPC_URL_HYPEREVM_FORK secret slot#286hardyjosh wants to merge 1 commit into
hardyjosh wants to merge 1 commit into
Conversation
The manual sol-artifacts workflow already carries a HyperEVM RPC slot; the shared test workflow did not, so callers' HyperEVM fork tests can never see HYPEREVM_RPC_URL in CI. Declare the secret on rainix-sol.yaml, forward it to the test job, and map it to HYPEREVM_RPC_URL alongside the other fork RPCs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VPs1hCTxusmaSeFKvoc4Kr
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Solidity GitHub Actions workflows now support an optional Hyperevm fork RPC secret, forward it to the test job, and expose it as ChangesHyperevm RPC configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manual sol-artifacts workflow gained a HyperEVM RPC slot in #279, but the shared test workflow (
rainix-sol.yaml→rainix-sol-test.yaml) did not — so callers' HyperEVM fork tests can never seeHYPEREVM_RPC_URLin PR CI and stay env-gated.This declares
RPC_URL_HYPEREVM_FORK(optional, like the other fork RPCs) onrainix-sol.yaml, forwards it to the test job, and maps it toHYPEREVM_RPC_URLalongside the other fork RPC env vars. No behaviour change for callers that don't set the secret.Unblocks S01-Issuer/st0x.deploy HyperEVM fork tests (RAI-1511).
🤖 Generated with Claude Code
https://claude.ai/code/session_01VPs1hCTxusmaSeFKvoc4Kr
Summary by CodeRabbit