Repository navigation
feat: pass wallet setup to providers when building them - #1556
Open
Ikari-Shinji-re wants to merge 1 commit into
Open
Ikari-Shinji-re wants to merge 1 commit into
Ikari-Shinji-re wants to merge 1 commit into
Conversation
Ikari-Shinji-re
requested review from
RyukTheCoder,
arlert-armin,
llawliet-l-l,
nikaaru and
yeager-eren
as code owners
November 16, 2026 13:14
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third step of moving wallet provider setup out of the widget.
Wallets that need setup (WalletConnect, TON Connect, Trezor, Ledger Wallet, OKX) used to get it from the widget, which mapped its own config fields onto hardcoded wallet ids at
hub.init. Now each provider takes its setup when it's built, so a provider is fully set up by whoever creates it.buildProvider(options)takes the setup. It's required for WalletConnect, TON Connect, Trezor and Ledger Wallet, and optional for OKX. WalletConnect still gets the blockchain meta at init.provider-all:allProviders(options)takes{ walletConnect, tonConnect, trezor, ledgerWallet, okx }and leaves out wallets whose setup is missing. OKX falls back totonConnect.wallets-react:configs.walletOptionsis removed.{ meta }at init, so no wallet ids are involved.Breaking: the five providers'
buildProvidernow take their setup, and wallets-react'sconfigs.walletOptionsis removed. The widget's config is unchanged.Fixes # (issue)
How did you test this change?
provider-all,wallets-reactandwidget-embeddedwallets-react(12) andwidget-embedded(86)Checklist: