Skip to content

Remove wheel-tests-cudf-polars-with-rapidsmpf in favor of existing wheel-tests-cudf-polars#22467

Open
mroeschke wants to merge 3 commits into
rapidsai:mainfrom
mroeschke:ci/cudf_polars/no_rmpf_job
Open

Remove wheel-tests-cudf-polars-with-rapidsmpf in favor of existing wheel-tests-cudf-polars#22467
mroeschke wants to merge 3 commits into
rapidsai:mainfrom
mroeschke:ci/cudf_polars/no_rmpf_job

Conversation

@mroeschke
Copy link
Copy Markdown
Contributor

Description

Now that rapidsmpf is a required dependency of cudf_polars, wheel-tests-cudf-polars-with-rapidsmpf was almost functionally identical to wheel-tests-cudf-polars. To make the former align to the latter:

  • ray is now installed in the wheel-tests-cudf-polars job
  • --ignore=tests/experimental was removed when running tests in wheel-tests-cudf-polars

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke self-assigned this May 11, 2026
@mroeschke mroeschke requested a review from a team as a code owner May 11, 2026 22:09
@mroeschke mroeschke requested a review from bdice May 11, 2026 22:09
@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 11, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2f18aac9-61be-42a8-a4f9-18505e8043e1

📥 Commits

Reviewing files that changed from the base of the PR and between 66ce2d0 and 45afe09.

📒 Files selected for processing (2)
  • ci/test_wheel_cudf_polars.sh
  • python/cudf_polars/tests/experimental/test_rolling.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci/test_wheel_cudf_polars.sh

📝 Walkthrough

Summary by CodeRabbit

  • Chores

    • Updated CI to consolidate and simplify PR test jobs and container settings.
    • Removed separate experimental test job; experimental tests are now part of the main workflow.
  • Tests

    • Experimental test suite now runs with the primary test pipeline.
    • Test environment now includes the Ray extra for relevant package installs.

Walkthrough

Consolidates cudf_polars experimental testing into the main wheel test workflow: removes the separate experimental job and scripts, adds container runtime options to the consolidated job, enables experimental tests in CI, and adds the ray extra to wheel installs.

Changes

Test Workflow Consolidation

Layer / File(s) Summary
Workflow Job Configuration
.github/workflows/pr.yaml
Update checks.ignored_pr_jobs to no longer reference the removed job and remove the wheel-tests-cudf-polars-with-rapidsmpf job so flow continues from wheel-tests-cudf-polars to downstream tests.
Container Runtime Configuration
.github/workflows/pr.yaml, .github/workflows/test.yaml
Add container-options to wheel-tests-cudf-polars (CAP_SYS_PTRACE, increased /dev/shm, raised nofile ulimit) in both workflows.
Remove Dedicated Experimental Test Scripts
ci/run_cudf_polars_experimental_pytests.sh, ci/test_cudf_polars_experimental.sh
Delete scripts that previously handled experimental wheel installation, constraint generation, Polars version selection, timeout-wrapped test execution, and exit-code capture.
Integrate Tests into Main Test Suite
ci/run_cudf_polars_pytests.sh, ci/test_wheel_cudf_polars.sh
Remove --ignore=tests/experimental so experimental tests run; add ray extra to the cudf_polars wheel install.
Tests / Warning Handling
python/cudf_polars/tests/experimental/test_rolling.py
Add module-level pytest.mark.filterwarnings to ignore a UserWarning about multi-partition unsupported behavior and remove the per-call pytest.warns(...) wrapper around the equality assertion.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • rapidsai/cudf#22420: Related CI changes enabling Ray in cudf_polars testing and adding container-options to workflows.

Suggested labels

Python, cudf-polars

Suggested reviewers

  • bdice
  • pentschev
  • jameslamb
  • msarahan
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: removing the redundant wheel-tests-cudf-polars-with-rapidsmpf job in favor of consolidating into the existing wheel-tests-cudf-polars job.
Description check ✅ Passed The description is directly related to the changeset, explaining why the job is being removed (rapidsmpf is now a required dependency) and what changes are made to align the remaining job.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@mroeschke mroeschke requested a review from a team as a code owner May 12, 2026 00:38
@github-actions github-actions Bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels May 12, 2026
@GPUtester GPUtester moved this to In Progress in cuDF Python May 12, 2026

# HStack may redirect to Select before fallback; message differs by Polars IR / version.
@pytest.mark.filterwarnings(
"ignore:This .*is not supported for multiple partitions:UserWarning"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on, does this fail if the query doesn't raise that warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cudf-polars Issues specific to cudf-polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

5 participants