[cudf_polars] Reorganize package layout#22491
Merged
rapids-bot[bot] merged 5 commits intoMay 19, 2026
Merged
Conversation
madsbk
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
Python
|
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
madsbk
requested review from
Matt711,
TomAugspurger,
mroeschke,
rjzamora and
wence-
madsbk
commented
May 14, 2026
Comment on lines
-132
to
-147
| def lower_dataframescan_rapidsmpf( | ||
| ir: DataFrameScan, rec: LowerIRTransformer | ||
| ) -> tuple[IR, MutableMapping[IR, PartitionInfo]]: | ||
| """Lower a DataFrameScan node for the RapidsMPF streaming runtime.""" | ||
| config_options = rec.state["config_options"] | ||
|
|
||
| # NOTE: We calculate the expected partition count | ||
| # to help trigger fallback warnings in lower_ir_graph. | ||
| # The generate_ir_sub_network logic is NOT required | ||
| # to obey this partition count. However, the count | ||
| # WILL match after an IO operation (for now). | ||
| rows_per_partition = config_options.executor.max_rows_per_partition | ||
| nrows = max(ir.df.shape()[0], 1) | ||
| count = math.ceil(nrows / rows_per_partition) | ||
|
|
||
| return ir, {ir: PartitionInfo(count=count)} |
Member
Author
There was a problem hiding this comment.
Removed lower_dataframescan_rapidsmpf from streaming/actor_graph/io.py (formerly experimental/rapidsmpf/io.py).
Its body are inlined verbatim into the existing @lower_ir_node.register(DataFrameScan) implementation in streaming/io.py (formerly experimental/io.py).
madsbk
commented
May 14, 2026
Comment on lines
-320
to
-348
| def lower_scan_rapidsmpf( | ||
| ir: Scan, rec: LowerIRTransformer | ||
| ) -> tuple[IR, MutableMapping[IR, PartitionInfo]]: | ||
| """Lower a Scan node for the RapidsMPF streaming runtime.""" | ||
| config_options = rec.state["config_options"] | ||
| if ( | ||
| ir.typ in ("csv", "parquet", "ndjson") | ||
| and ir.n_rows == -1 | ||
| and ir.skip_rows == 0 | ||
| and ir.row_index is None | ||
| ): | ||
| # NOTE: We calculate the expected partition count | ||
| # to help trigger fallback warnings in lower_ir_graph. | ||
| # The generate_ir_sub_network logic is NOT required | ||
| # to obey this partition count. However, the count | ||
| # WILL match after an IO operation (for now). | ||
| plan = scan_partition_plan(ir, rec.state["stats"], config_options) | ||
| paths = list(ir.paths) | ||
| if plan.flavor == IOPartitionFlavor.SPLIT_FILES: | ||
| count = plan.factor * len(paths) | ||
| else: | ||
| count = math.ceil(len(paths) / plan.factor) | ||
|
|
||
| return ir, {ir: PartitionInfo(count=count, io_plan=plan)} | ||
| else: | ||
| plan = IOPartitionPlan( | ||
| flavor=IOPartitionFlavor.SINGLE_READ, factor=len(ir.paths) | ||
| ) | ||
| return ir, {ir: PartitionInfo(count=1, io_plan=plan)} |
Member
Author
There was a problem hiding this comment.
Removed lower_scan_rapidsmpf from streaming/actor_graph/io.py (formerly experimental/rapidsmpf/io.py).
Its body are inlined verbatim into the existing @lower_ir_node.register(Scan) implementation in streaming/io.py (formerly experimental/io.py).
madsbk
force-pushed
the
reorganize-package-layout
branch
2 times, most recently
from
9f3df89 to
019cc0d
Compare
madsbk
force-pushed
the
reorganize-package-layout
branch
from
019cc0d to
774de38
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
wence-
approved these changes
May 19, 2026
bdice
approved these changes
May 19, 2026
Matt711
approved these changes
May 19, 2026
Member
Author
|
/merge |
madsbk
added a commit
to madsbk/cudf
that referenced
this pull request
May 19, 2026
This PR is pure moving/renaming.
### New layout
```
cudf_polars/
callback.py
containers/
dsl/
engine/ ← user-facing GPU engine classes (Streaming/Ray/Dask/SPMD/DefaultSingleton)
streaming/ ← multi-partition execution layer (formerly "experimental")
actor_graph/ ← RapidsMPF-backed runtime
collectives/ ← RapidsMPF collective communication primitives
benchmarks/
utils.py ← consolidated benchmark utilities (formerly split between utils.py shim and utils_new_frontends.py)
pdsds.py
...
base.py
dispatch.py
parallel.py
groupby.py
io.py
join.py
...
testing/
typing/
utils/
```
Engine entry points move from deeply nested experimental paths to top-level imports:
```
cudf_polars.experimental.rapidsmpf.frontend.options → cudf_polars.engine.options
cudf_polars.experimental.rapidsmpf.frontend.spmd → cudf_polars.engine.spmd
cudf_polars.experimental.rapidsmpf.frontend.ray → cudf_polars.engine.ray
cudf_polars.experimental.rapidsmpf.frontend.dask → cudf_polars.engine.dask
cudf_polars.experimental.rapidsmpf.frontend.core → cudf_polars.engine.core
```
Benchmarks is now under `streaming`:
```
python -m cudf_polars.streaming.benchmarks.pdsh
```
Authors:
- Mads R. B. Kristensen (https://github.com/madsbk)
Approvers:
- Lawrence Mitchell (https://github.com/wence-)
- Peter Andreas Entschev (https://github.com/pentschev)
- Bradley Dice (https://github.com/bdice)
- Matthew Murray (https://github.com/Matt711)
URL: rapidsai#22491
rapids-bot Bot
pushed a commit
that referenced
this pull request
May 19, 2026
- Follow up to #22491 - Moves the `collectives` module under `actor_graph` to break circular dependencies. The "collectives" are **mostly** used to build the actor graph anyway. **Note**: Before merging this, I'd like to get confirmation that others see circular-import errors locally. E.g. ``` pytest -v python/cudf_polars/tests/streaming/test_groupby.py ... E ImportError: cannot import name 'ShuffleManager' from partially initialized module 'cudf_polars.streaming.collectives.shuffle' (most likely due to a circular import) (/raid/rzamora/rapids-26.06/cudf/python/cudf_polars/cudf_polars/streaming/collectives/shuffle.py) ``` Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) Approvers: - Matthew Murray (https://github.com/Matt711) - Mads R. B. Kristensen (https://github.com/madsbk) URL: #22578
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is pure moving/renaming.
New layout
Engine entry points move from deeply nested experimental paths to top-level imports:
Benchmarks is now under
streaming: