Skip to content

[release/26.06] Remove stale import of deleted assert_collect_raises#22558

Merged
rapids-bot[bot] merged 2 commits into
rapidsai:release/26.06from
madsbk:delete-assert_collect_raises
May 19, 2026
Merged

[release/26.06] Remove stale import of deleted assert_collect_raises#22558
rapids-bot[bot] merged 2 commits into
rapidsai:release/26.06from
madsbk:delete-assert_collect_raises

Conversation

@madsbk
Copy link
Copy Markdown
Member

@madsbk madsbk commented May 18, 2026

Description

PR #22048 (merged today) added the new test_hconcat_strict_different_heights test, which imports assert_collect_raises. However, PR #22535 (also merged today) removed that helper.

The two PRs landed on release/26.06 without the conflict being noticed.

On main, test_hconcat.py does not contain the strict-mode test, so the issue is limited to release/26.06.

PR rapidsai#22048 ("Bump polars upper bound to <1.40", merged today) added the new
`test_hconcat_strict_different_heights` test, which imports
`assert_collect_raises`. However, PR rapidsai#22535 ("Clean up legacy test
scaffolding", also merged into `release/26.06`) removed that helper.

The two PRs landed on `release/26.06` without the conflict being noticed.

On `main`, `test_hconcat.py` does not contain the strict-mode test, so the
issue is limited to `release/26.06`.
@madsbk madsbk self-assigned this May 18, 2026
@madsbk madsbk added bug Something isn't working non-breaking Non-breaking change labels May 18, 2026
@github-actions github-actions Bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels May 18, 2026
@GPUtester GPUtester moved this to In Progress in cuDF Python May 18, 2026
@madsbk madsbk marked this pull request as ready for review May 18, 2026 20:30
@madsbk madsbk requested a review from a team as a code owner May 18, 2026 20:30
@madsbk madsbk requested a review from Matt711 May 18, 2026 20:30
@rapidsai rapidsai deleted a comment from copy-pr-bot Bot May 18, 2026
@madsbk madsbk requested a review from mroeschke May 18, 2026 20:31
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a3cdb814-83c2-469c-85d7-091219ce66a3

📥 Commits

Reviewing files that changed from the base of the PR and between 2151706 and 0b189cd.

📒 Files selected for processing (1)
  • python/cudf_polars/tests/test_hconcat.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • python/cudf_polars/tests/test_hconcat.py

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Strengthened tests for horizontal concatenation with mismatched heights by adding explicit exception checks that cover both collection execution modes.
    • Removed reliance on a prior test-helper assertion and streamlined imports to simplify test validation of error handling.

Walkthrough

Test file test_hconcat.py removes the assert_collect_raises import and replaces its usage in test_hconcat_strict_different_heights with explicit pytest.raises(pl.exceptions.ShapeError) checks for both standard and GPU-engine collect calls.

Changes

Test assertion refactoring

Layer / File(s) Summary
Remove legacy assertion helper and update test
python/cudf_polars/tests/test_hconcat.py
Import statement removes assert_collect_raises dependency; test assertions rewritten as two explicit pytest.raises(pl.exceptions.ShapeError) blocks covering both q.collect() and q.collect(engine=pl.GPUEngine(executor="in-memory", raise_on_fail=True)).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • rapidsai/cudf#22535: Main PR that updates the same test file to stop using the legacy assert_collect_raises helper and replace it with explicit pytest.raises.

Suggested labels

improvement

Suggested reviewers

  • nirandaperera
  • wence-
  • mroeschke
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing a stale import of a deleted helper function.
Description check ✅ Passed The description clearly explains the context and rationale for the fix, detailing which PRs caused the issue.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@madsbk
Copy link
Copy Markdown
Member Author

madsbk commented May 18, 2026

/merge

1 similar comment
@mroeschke
Copy link
Copy Markdown
Contributor

/merge

@rapids-bot rapids-bot Bot merged commit 2a452f4 into rapidsai:release/26.06 May 19, 2026
159 of 161 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in cuDF Python May 19, 2026
@madsbk madsbk deleted the delete-assert_collect_raises branch May 19, 2026 07:17
madsbk added a commit to madsbk/cudf that referenced this pull request May 19, 2026
rapidsai#22558)

PR rapidsai#22048 (merged today) added the new `test_hconcat_strict_different_heights` test, which imports `assert_collect_raises`. However, PR rapidsai#22535 (also merged today) removed that helper.

The two PRs landed on `release/26.06` without the conflict being noticed.

On `main`, `test_hconcat.py` does not contain the strict-mode test, so the issue is limited to `release/26.06`.

Authors:
  - Mads R. B. Kristensen (https://github.com/madsbk)

Approvers:
  - Matthew Murray (https://github.com/Matt711)

URL: rapidsai#22558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cudf-polars Issues specific to cudf-polars non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants