Minimize Dask resource acquisition in cudf_polars tests#22646
Minimize Dask resource acquisition in cudf_polars tests#22646mroeschke wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR refactors Dask engine test fixtures to support both centralized configuration and explicit client injection. It adds a shared ChangesDask Engine Fixture Refactoring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Description
The motivation is to help alleviate potential CI issues due to Dask/Ray resource spin-up in cudf_polars tests, starting with
test_dask.pytest_scan,test_filter,test_group_by,test_join, andtest_empty_dataframeas they already have coverage in other test where we parameterize overengineDaskEngine, uses the session-scopedDaskEnginealready created inconftest.pyDaskEngineconstruction, uses a module-scopeddask_clientwith aLocalCluster(tests that use this are just testing engine properties so just uses 1 worker)Overall, this PR reduces the 5 Dask clusters allocated to just 2
Checklist