Skip to content

ensure latest tag is used to determine versions#694

Open
jameslamb wants to merge 1 commit intorapidsai:mainfrom
jameslamb:tag-parsing
Open

ensure latest tag is used to determine versions#694
jameslamb wants to merge 1 commit intorapidsai:mainfrom
jameslamb:tag-parsing

Conversation

@jameslamb
Copy link
Copy Markdown
Member

Contributes to https://github.com/rapidsai/github-infrastructure/issues/63

Mistakes in forward-mergers can sometimes lead to a weird mix of tags in git history, which can trip up logic that relies on those tags to compute things like versions for image URIs.

git describe --tags --first-parent ensures we get the expected behavior (version = tag "closest" to HEAD) even when mistakes are made in the forward-merger process.

See rapidsai/docker#867 and https://github.com/rapidsai/github-infrastructure/issues/63 for much more detail.

Notes for Reviewers

How I tested this

These commands are equivalent on main here.

$ git checkout main
$ git fetch upstream --tags
$ git describe --abbrev=0 --tags
v26.06.00a

$ git describe --abbrev=0 --tags --first-parent
v26.06.00a

Just doing this preventatively.

@jameslamb jameslamb requested a review from trxcllnt May 6, 2026 19:25
@jameslamb jameslamb requested a review from a team as a code owner May 6, 2026 19:25
@jameslamb jameslamb requested review from gforsyth and removed request for a team May 6, 2026 19:25
@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 6, 2026
Copy link
Copy Markdown
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of preventative measure.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants