[REVIEW] Add all-to-all, scatter, and scatterv functions to raft::comms_t#3002
Open
seunghwak wants to merge 10 commits intorapidsai:mainfrom
Open
[REVIEW] Add all-to-all, scatter, and scatterv functions to raft::comms_t#3002seunghwak wants to merge 10 commits intorapidsai:mainfrom
seunghwak wants to merge 10 commits intorapidsai:mainfrom
Conversation
seunghwak
added
enhancement
seunghwak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ncclAlltoAll,ncclScatter, andncclGatherwas added in NCCL 2.28.3.We previously performed all-to-all using multi-cast and gather was performed using send/receive.
raft::comms_tlacks scatter and scatterv.This PR adds alltoall (
ncclAlltoAllwrapper), scatter (ncclScatterwrapper), and scatterv (implemented using send/receive).This PR also updates gather to directly call
ncclGather(instead of emulating gather using send/receive).