Fix large-message initialization in communication benchmark#1016
Open
pentschev wants to merge 1 commit intorapidsai:mainfrom
Open
Fix large-message initialization in communication benchmark#1016pentschev wants to merge 1 commit intorapidsai:mainfrom
pentschev wants to merge 1 commit intorapidsai:mainfrom
Conversation
`bench_comm` could fail while initializing input buffers for per-peer messages at around 8 GiB and larger, before the benchmark itself ran. This change allows large-message all-to-all cases to run correctly.
pentschev
added
bug
Comment on lines
+31
to
+34
| RAPIDSMPF_EXPECTS( | ||
| nelem <= static_cast<std::size_t>(std::numeric_limits<index_t>::max()), | ||
| "random_device_vector size exceeds signed iterator range" | ||
| ); |
Contributor
There was a problem hiding this comment.
Nit. Do we consider 32-bit systems? For 64 bit nelem > INT64_MAX seems unlikely isnt it?
| } | ||
|
|
||
| std::unique_ptr<cudf::column> random_column( | ||
| cudf::size_type nrows, |
Contributor
There was a problem hiding this comment.
Shouldnt this be std::size_t now to reflect the above change? Otherwise we will be clipping values above UINT32_MAX, isnt it?
Contributor
There was a problem hiding this comment.
You can't make a column with more than size_type::max rows, so I think the point is moot?
Comment on lines
-75
to
+90
| buffer.size / sizeof(std::int32_t) + sizeof(std::int32_t), | ||
| (buffer.size + sizeof(std::int32_t) - 1) / sizeof(std::int32_t), |
Contributor
There was a problem hiding this comment.
if buffer is empty now, we will be passing 0 to random_device_vector. I think random_fill was trying to prevent that before? I'm not sure.
|
|
||
| cudf::table random_table( | ||
| cudf::size_type ncolumns, | ||
| cudf::size_type nrows, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bench_commcould fail while initializing input buffers for per-peer messages at around 8 GiB and larger, before the benchmark itself ran. This change allows large-message all-to-all cases to run correctly.