Add build-devcontainers.yaml and build-devcontainer.yaml workflows#530
Open
trxcllnt wants to merge 6 commits into
Open
Add build-devcontainers.yaml and build-devcontainer.yaml workflows#530trxcllnt wants to merge 6 commits into
build-devcontainers.yaml and build-devcontainer.yaml workflows#530trxcllnt wants to merge 6 commits into
Conversation
…build-devcontainer
trxcllnt
added
improvement
bdice
approved these changes
May 12, 2026
| For example, if a repository has directories '.devcontainer/cuda12.9-pip/' and '.devcontainer/cuda13.1-pip/', | ||
| '["12.9", "13.1"]' could be passed here to build both of those devcontainers in CI. | ||
| type: string | ||
| default: '["12.9", "13.1"]' |
Contributor
There was a problem hiding this comment.
Just a note that this may need to be changed. We're in the process of updating 13.1 to 13.2. Not all repos have the same devcontainers right now, depending on whether they've been updated.
I'd lean towards making this a required input with no default, so that we have one fewer place to update CUDA versions (both per-repo and the default value).
| EOF | ||
|
|
||
| - name: Clean up untagged images | ||
| uses: snok/container-retention-policy@3b0972b2276b171b212f8c4efbca59ebba26eceb |
Contributor
There was a problem hiding this comment.
Suggested change
| uses: snok/container-retention-policy@3b0972b2276b171b212f8c4efbca59ebba26eceb | |
| uses: snok/container-retention-policy@3b0972b2276b171b212f8c4efbca59ebba26eceb # v3.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add workflows to build and publish devcontainers to
ghcr.ioso we can usecacheFromto speed up devcontainer launch times.Depends on rapidsai/shared-actions#104