Samples review#2478
Open
mateuszbartosik wants to merge 4 commits into
Open
Conversation
Add OverflowTagRow, a reusable row that measures tag widths via a ResizeObserver and collapses overflow into a "+X more" pill, keeping each category row on a single line and adapting to the card's own width. Clicking the pill expands the row. In SampleCard, render the Challenges & Solutions and Features rows through OverflowTagRow and move selected (matching) tags to the front so the reason a card matched stays visible after filtering.
Generalize OverflowTagRow to also handle permalink-based tags and move it to components/Common so it can be shared. Use it in CardWithImage (the guide grid cards, homepage use cases, and tag-doc list) in place of the fixed two-tag useTagLimit, so tags fill the available width on a single line before collapsing into a width-aware "+X more" pill.
Introduce samples/order.yml as the single source of truth for the /samples hub ordering and have recent-samples-plugin sort indexed samples by it. Listed samples render first in the given order; any unlisted sample follows, sorted alphabetically by title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RDoc-3888
Additional description
order.ymlfile responsible for ordering will be implemented. It will allow to manually adjust the order, with a fallback of items not specified being sorted alphabetically.Type of change
/templatesor readme)Changes in docs URLs
/scripts/redirects.jsonfile, setDocuments MovedPR label)Changes in UX/UI