-
Notifications
You must be signed in to change notification settings - Fork 0
Document what a configuration change requires #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
3
commits into
main
Choose a base branch
from
devin/1786379042-config-change-phases-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| --- | ||
| title: "What happens after a configuration change?" | ||
| description: "Understand which Ravion phases a module configuration change requires." | ||
| "og:image": "https://www.ravion.com/og/docs/config-as-code/configuration-changes.png" | ||
| "twitter:image": "https://www.ravion.com/og/docs/config-as-code/configuration-changes.png" | ||
| --- | ||
|
|
||
| When you change a module input, Ravion identifies the operational phases | ||
| required for the change to take effect. Saving the configuration does not | ||
| necessarily run every required phase. | ||
|
|
||
| For background on managing a project configuration file, see [Project config | ||
| file](/config-as-code/project-config-file). | ||
|
|
||
| ## The phases | ||
|
|
||
| | Phase | What it does | | ||
| | --- | --- | | ||
| | **Stack update** | Runs the module's stack pipeline to create or update infrastructure. | | ||
| | **Rebuild** | Creates a new application image or other build artifact. | | ||
| | **Deploy** | Releases the new configuration or artifact to the running module. | | ||
|
|
||
| The phases are separate. A stack update changes infrastructure, but does not | ||
| release a new application artifact. A rebuild creates an artifact, but does not | ||
| make it the active release until a deploy promotes it. | ||
|
|
||
| See [Build](/modules/build) and [Deploy](/modules/deploy) for more about those | ||
| pipeline steps. | ||
|
|
||
| ## Examples | ||
|
|
||
| The required phases depend on the module definition and the input you change. | ||
| These examples use inputs from Ravion's standard module definitions: | ||
|
|
||
| | Module input | Required phases | Why | | ||
| | --- | --- | --- | | ||
| | `rvn-ecs-web` `desired_count` | Stack update | The desired service capacity is infrastructure configuration. | | ||
| | `rvn-ec2-service` `environment_variables` or `secrets` | Stack update and deploy | The stack carries the runtime configuration, and the deploy renders it into the app environment on running instances. | | ||
| | `rvn-aws-static` `build_environment_variables` | Rebuild and deploy | The build uploads a versioned static directory, and the deploy promotes that directory to production. | | ||
|
|
||
| The per-input `applies_on` field records this lifecycle metadata in a module | ||
| definition. See the [module definition schema reference](/module-definitions/definition-schema/inputs). | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This page directs module authors to the input schema reference for Prompt To Fix With AIThis is a comment left during a code review.
Path: config-as-code/configuration-changes.mdx
Line: 41-42
Comment:
**Linked schema omits `applies_on`**
This page directs module authors to the input schema reference for `applies_on`, but that generated reference does not define the field or its accepted values, leaving authors unable to use the documented lifecycle metadata.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly. |
||
|
|
||
| ## Check what a change requires | ||
|
|
||
| ### Dashboard | ||
|
|
||
| When you save a module configuration, the confirmation dialog shows which | ||
| phases the change requires and what the selected save option will do. | ||
|
|
||
| Saving the configuration records the new values. It does not automatically | ||
| rebuild an artifact or deploy it unless you choose an option that performs | ||
| those operations. If a later phase is required, run that phase after the | ||
| configuration save completes. | ||
|
|
||
| ### CLI | ||
|
|
||
| The `ravion project config apply` command shows the required phases in the | ||
| `REQUIRES` column. In an interactive terminal, it also displays the planned | ||
| changes and asks you to confirm them: | ||
|
|
||
| ```bash | ||
| ravion project config apply <project-id> --file ravion.yaml | ||
| ``` | ||
|
|
||
| Use a dry run to inspect the plan without applying it: | ||
|
|
||
| ```bash | ||
| ravion project config apply <project-id> \ | ||
| --file ravion.yaml \ | ||
| --dry-run | ||
| ``` | ||
|
|
||
| Use `--yes` to skip the confirmation prompt in scripts: | ||
|
|
||
| ```bash | ||
| ravion project config apply <project-id> \ | ||
| --file ravion.yaml \ | ||
| --yes | ||
| ``` | ||
|
|
||
| The `REQUIRES` column uses **stack update**, **rebuild**, and **deploy** so you | ||
| can see which work remains after the configuration apply. | ||
|
|
||
| ## Older module definitions | ||
|
|
||
| <Warning> | ||
| Module definitions published before lifecycle metadata was introduced do not | ||
| provide enough information to determine every required phase. | ||
| </Warning> | ||
|
|
||
| If Ravion reports unknown phase metadata, assume the change requires a stack | ||
| update and a deploy. Run the stack update, rebuild if the module needs a new | ||
| artifact, and then deploy the resulting configuration or artifact. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be build not rebuild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in e505467 — "build" everywhere now. Also swapped the page's "phase" vocabulary for "action" to match the rename landing in the API/CLI.