-
Notifications
You must be signed in to change notification settings - Fork 0
RDS proxy #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,689
−41
Merged
RDS proxy #94
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
52b5681
add RDS Proxy module
mabadir 6dfb881
update readme
mabadir d45817b
Add RDS Proxy test coverage and fix master secret handling
mabadir 1ab55b2
Merge main and resolve RDS proxy conflicts
mabadir e669423
fix: bump aurora/rds definitions and break proxy SG cycle
mabadir 149815f
feat: reference RDS/Aurora modules as RDS Proxy targets
mabadir 5fa0997
fix: fold RDS Proxy target source into the target type toggle
mabadir 0ca58ed
fix: drop RDS Proxy manual target identifier inputs
mabadir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| ################################################################################ | ||
| # RDS Proxy (optional) | ||
| ################################################################################ | ||
|
|
||
| module "proxy" { | ||
| count = local.create_proxy ? 1 : 0 | ||
|
|
||
| source = "../rds-proxy" | ||
|
|
||
| name = var.name | ||
| engine_family = local.proxy_engine_family | ||
| vpc_id = var.vpc_id | ||
| subnet_ids = var.subnet_ids | ||
| port = local.port | ||
| tags = var.tags | ||
|
|
||
| db_cluster_identifier = aws_rds_cluster.this.cluster_identifier | ||
|
|
||
| auth = [ | ||
| for arn in local.proxy_auth_secret_arns : { | ||
| secret_arn = arn | ||
| iam_auth = var.proxy_iam_auth_enabled ? "REQUIRED" : "DISABLED" | ||
| } | ||
| ] | ||
| secret_kms_key_arns = local.proxy_secret_kms_key_arns | ||
|
|
||
| tls_requirement_enabled = var.proxy_tls_requirement_enabled | ||
| debug_logging_enabled = var.proxy_debug_logging_enabled | ||
| idle_client_timeout = var.proxy_idle_client_timeout | ||
|
|
||
| connection_borrow_timeout = var.proxy_connection_borrow_timeout | ||
| init_query = var.proxy_init_query | ||
| max_connections_percent = var.proxy_max_connections_percent | ||
| max_idle_connections_percent = var.proxy_max_idle_connections_percent | ||
| session_pinning_filters = var.proxy_session_pinning_filters | ||
|
|
||
| allowed_security_group_ids = var.allowed_security_group_ids | ||
| allowed_cidr_blocks = var.allowed_cidr_blocks | ||
|
|
||
| # Registering an Aurora cluster as a proxy target requires the cluster to | ||
| # already have at least one instance. | ||
| depends_on = [aws_rds_cluster_instance.this] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
proxy_creation_enableduses the default module-managed security group, the database depends on this security group, this rule depends on the proxy module, and the proxy targets the same database, causing Terraform to report a dependency cycle and reject the plan for both the Aurora and RDS integrations.Knowledge Base Used: Database Modules: Aurora, RDS, DynamoDB
Prompt To Fix With AI