Repository navigation
Conversation
The status item is now cursorarrow.rays while Heed is on and a plain cursorarrow while it is off, decided in MenuBarState where it is tested, so the state shows by shape as well as by dimming, which also means "no permission". SF Symbols come out as templates, match the weight of the neighbouring items and follow appearance changes for free; the flash draws its colour into the image through a palette configuration, since a template is a mask. The hand-drawn hexagon is gone.
The app icon is now the same cursorarrow.rays symbol the menu bar item shows, white on a dark tile, rendered by make-icon.swift through AppKit so the two cannot drift apart. The wireframe cube is gone from both places.
Owner
Author
|
Folded into #18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The menu bar item is now an SF Symbol:
cursorarrow.rayswhile Heed is on and a plaincursorarrowwhile it is off, so the switch position shows by shape as well as by dimming, which also means "no permission". The choice lives inMenuBarState, where it is tested. Symbols come out as templates, match the weight of the neighbouring items and follow appearance changes for free; the flash draws its colour into the image through a palette configuration, since a template is a mask.The app icon is the same symbol, white on a dark tile, rendered by
make-icon.swiftthrough AppKit so the two cannot drift apart. The wireframe cube is gone from both places.Checked by rendering the iconset and reviewing the 512, 32 and 16 pixel results, by
make check-package, and by installing the build and using it: the glyph changes shape with the switch and the flash colours render.