Adjust plugins to new Thunder/interfaces#966
Open
nxtum wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows/MSVC project configurations and a couple of example interface modules to match the newer Thunder header layout (notably moving interface headers under interfaces/) and to ensure $(ContractsPath) is available early in include resolution.
Changes:
- Reordered/updated
AdditionalIncludeDirectoriesin multiple.vcxprojfiles to prioritize$(ContractsPath)before$(FrameworkPath)(and added$(ContractsPath)where missing). - Updated DynamicLoading example interface modules to include Thunder headers from
<interfaces/...>instead of<plugins/...>. - Updated
SimpleCOMRPCInterface’s ProxyStubGenerator invocation to also search$(ContractsPath).
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/TestPriorityQueue/test_app/test_app.vcxproj | Prioritizes $(ContractsPath) in include directories for the test app project. |
| tests/TestPriorityQueue/TestPriorityQueue.vcxproj | Prioritizes $(ContractsPath) in include directories across configurations. |
| examples/SimpleCOMRPCServer/SimpleCOMRPCServer.vcxproj | Adds/prioritizes $(ContractsPath) in include directories. |
| examples/SimpleCOMRPCInterface/SimpleCOMRPCInterface.vcxproj | Adds/prioritizes $(ContractsPath) in includes and adds -I $(ContractsPath) to ProxyStubGenerator. |
| examples/SimpleCOMRPC/PluginServer/SimpleCOMRPCPluginServer.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| examples/SimpleCOMRPC/Client/SimpleCOMRPCClient.vcxproj | Adds/prioritizes $(ContractsPath) in include directories. |
| examples/OutOfProcessPlugin/OutOfProcessPlugin.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| examples/JSONRPC/Plugin/JSONRPCPlugin.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| examples/JSONRPC/Client/JSONRPCClient.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| examples/DynamicLoading/Yin/interfaces/Module.h | Switches Thunder interface includes from <plugins/...> to <interfaces/...>. |
| examples/DynamicLoading/Yang/interfaces/Module.h | Switches Thunder interface includes from <plugins/...> to <interfaces/...>. |
| examples/CustomErrorCodes/CustomErrorCode/CustomErrorCodeServer.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| examples/CustomErrorCodes/CustomCodeToStringLibrary/CustomCodeToStringLibrary.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| examples/COMRPCClient/COMRPCClient.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| WifiControl/WifiControl.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| WebServer/WebServer.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| WebProxy/WebProxy.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| TimeSync/TimeSync.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| Svalbard/Svalbard.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| SubsystemController/SubsystemControl.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| ScriptEngine/ScriptEngine.vcxproj | Reorders include directories to prioritize $(ContractsPath) ahead of framework/extension includes. |
| RemoteControl/RemoteControl.vcxproj | Reorders include directories to prioritize $(ContractsPath) and updates link dependencies from virtualinput.lib to plugins.lib. |
| NetworkControl/NetworkControl.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| Dictionary/Dictionary.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| DIALServer/DIALServer.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| DHCPServer/DHCPServer.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| Compositor/lib/RPI/CompositorImplementation.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| Compositor/Compositor.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| Commander/Commander.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
| BackOffice/BackOffice.vcxproj | Reorders include directories to prioritize $(ContractsPath). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged with:
rdkcentral/ThunderClientLibraries#336
WebPlatformForEmbedded/ThunderNanoServicesRDK#379
rdkcentral/ThunderInterfaces#476
rdkcentral/Thunder#2102